Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: content/browser/cocoa/system_hotkey_map_unittest.mm

Issue 1853533002: Add default hotkey dictionary for com.apple.symbolichotkeys.plist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: avi's review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/cocoa/system_hotkey_map.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/cocoa/system_hotkey_map_unittest.mm
diff --git a/content/browser/cocoa/system_hotkey_map_unittest.mm b/content/browser/cocoa/system_hotkey_map_unittest.mm
index 37638d472ac6666a551c29c9285a32cba2bc087e..a0798bec2410cea8c57b79699a867269dbd10388 100644
--- a/content/browser/cocoa/system_hotkey_map_unittest.mm
+++ b/content/browser/cocoa/system_hotkey_map_unittest.mm
@@ -134,13 +134,13 @@ TEST_F(SystemHotkeyMapTest, ParseMouse) {
bool result = map.ParseDictionary(dictionary);
EXPECT_TRUE(result);
- // Command + ` is a common key binding. It is missing.
- // TODO(erikchen): OSX uses the default value when the keybinding is missing,
- // so the hotkey should still be reserved.
- // http://crbug.com/383558
+ // Command + ` is a common key binding. It is missing, but since OS X uses the
+ // default value the hotkey should still be reserved.
+ // https://crbug.com/383558
+ // https://crbug.com/145062
unsigned short key_code = kVK_ANSI_Grave;
NSUInteger modifiers = NSCommandKeyMask;
- EXPECT_FALSE(map.IsHotkeyReserved(key_code, modifiers));
+ EXPECT_TRUE(map.IsHotkeyReserved(key_code, modifiers));
// There is a mouse keybinding for 0x08. It should not apply to keyboard
// hotkeys.
« no previous file with comments | « content/browser/cocoa/system_hotkey_map.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698