Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1853503004: Revert of Update BookmarkBarController to use non-deprecated dragging APIs. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp20_107_bluetooth
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update BookmarkBarController to use non-deprecated dragging APIs. (patchset #7 id:120001 of https://codereview.chromium.org/1815053002/ ) Reason for revert: Prevents drag and drop from bookmark bar to tabstrip: https://bugs.chromium.org/p/chromium/issues/detail?id=599522 Original issue's description: > Update BookmarkBarController to use non-deprecated dragging APIs. > > This CL theoretically should not produce any behavior change. > > This CL replaces the method -[NSView dragImage:...] with -[NSView > beginDraggingSessionWithItems:...]. There are three major differences. > > 1. The new API is asynchronous, whereas the old one ran a nested run loop. This > CL runs a nested run loop to maintain the previous behavior. > 2. The new API makes use of some new terminology and protocols > (NSDraggingSession, NSDraggingSource, etc.) but the underlying logic is still > the same. This CL renames some methods and variables. > 3. The new API requires that custom PasteBoard types use reverse DNS notation. > > BUG=592663 > > Committed: https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f > Cr-Commit-Position: refs/heads/master@{#382722} TBR=avi@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=592663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -81 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 11 chunks +33 lines, -55 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm View 1 chunk +7 lines, -19 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
erikchen
Created Revert of Update BookmarkBarController to use non-deprecated dragging APIs.
4 years, 8 months ago (2016-04-01 14:55:19 UTC) #1
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 14:55:28 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698