DescriptionRevert of Update BookmarkBarController to use non-deprecated dragging APIs. (patchset #7 id:120001 of https://codereview.chromium.org/1815053002/ )
Reason for revert:
Prevents drag and drop from bookmark bar to tabstrip:
https://bugs.chromium.org/p/chromium/issues/detail?id=599522
Original issue's description:
> Update BookmarkBarController to use non-deprecated dragging APIs.
>
> This CL theoretically should not produce any behavior change.
>
> This CL replaces the method -[NSView dragImage:...] with -[NSView
> beginDraggingSessionWithItems:...]. There are three major differences.
>
> 1. The new API is asynchronous, whereas the old one ran a nested run loop. This
> CL runs a nested run loop to maintain the previous behavior.
> 2. The new API makes use of some new terminology and protocols
> (NSDraggingSession, NSDraggingSource, etc.) but the underlying logic is still
> the same. This CL renames some methods and variables.
> 3. The new API requires that custom PasteBoard types use reverse DNS notation.
>
> BUG=592663
>
> Committed: https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f
> Cr-Commit-Position: refs/heads/master@{#382722}
TBR=avi@chromium.org,mark@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=592663
Patch Set 1 #
Messages
Total messages: 4 (2 generated)
|