Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1853463004: [heap] Abort AdvanceIncrementalMarking when we do not make marking progress. (Closed)

Created:
4 years, 8 months ago by Hannes Payer (out of office)
Modified:
4 years, 8 months ago
Reviewers:
ulan
CC:
ulan, Hannes Payer (out of office), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Abort AdvanceIncrementalMarking when we do not make marking progress. BUG=v8:4804 LOG=n Committed: https://crrev.com/3283d6d3500231420303a3cff01a24d126451da1 Cr-Commit-Position: refs/heads/master@{#35205}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/heap/incremental-marking.cc View 2 chunks +8 lines, -4 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/1853463004/diff/20001/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (left): https://codereview.chromium.org/1853463004/diff/20001/src/heap/incremental-marking.cc#oldcode1186 src/heap/incremental-marking.cc:1186: } else if (state_ == MARKING) { This is ...
4 years, 8 months ago (2016-04-01 12:48:24 UTC) #2
ulan
lgtm
4 years, 8 months ago (2016-04-01 12:54:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853463004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853463004/20001
4 years, 8 months ago (2016-04-01 13:00:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 13:25:21 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 13:25:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3283d6d3500231420303a3cff01a24d126451da1
Cr-Commit-Position: refs/heads/master@{#35205}

Powered by Google App Engine
This is Rietveld 408576698