🍯 Reland of GN: Allow android lint to fail builds

build/android/gyp/lint.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Android's lint tool."""
 
 
 import argparse
@@ skipping 201 matching lines @@
                       help='Path to lint executable.')
   parser.add_argument('--product-dir', required=True,
                       help='Path to product dir.')
   parser.add_argument('--result-path', required=True,
                       help='Path to XML lint result file.')
   parser.add_argument('--cache-dir', required=True,
                       help='Path to the directory in which the android cache '
                            'directory tree should be stored.')
   parser.add_argument('--platform-xml-path', required=True,
                       help='Path to api-platforms.xml')
-  parser.add_argument('--create-cache', action='store_true',
-                      help='Mark the lint cache file as an output rather than '
-                      'an input.')
   parser.add_argument('--can-fail-build', action='store_true',
                       help='If set, script will exit with nonzero exit status'
                            ' if lint errors are present')
   parser.add_argument('--config-path',
                       help='Path to lint suppressions file.')
   parser.add_argument('--enable', action='store_true',
                       help='Run lint instead of just touching stamp.')
   parser.add_argument('--jar-path',
                       help='Jar file containing class files.')
   parser.add_argument('--java-files',
@@ skipping 34 matching lines @@
       input_paths.append(args.config_path)
     if args.jar_path:
       input_paths.append(args.jar_path)
     if args.manifest_path:
       input_paths.append(args.manifest_path)
     if args.resource_dir:
       input_paths.extend(build_utils.FindInDirectory(args.resource_dir, '*'))
     if sources:
       input_paths.extend(sources)
 
-    input_strings = []
+    input_strings = [
+        args.can_fail_build,
+        args.silent,
+    ]
     if args.processed_config_path:
       input_strings.append(args.processed_config_path)
 
     output_paths = [ args.result_path ]
 
     build_utils.CallAndWriteDepfileIfStale(
         lambda changes: _OnStaleMd5(changes, args.lint_path,
                                     args.config_path,
                                     args.processed_config_path,
                                     args.manifest_path, args.result_path,
                                     args.product_dir, sources,
                                     args.jar_path,
                                     args.cache_dir,
                                     resource_dir=args.resource_dir,
                                     can_fail_build=args.can_fail_build,
                                     silent=args.silent),
         args,
         input_paths=input_paths,
         input_strings=input_strings,
         output_paths=output_paths,
         pass_changes=True)
 
 
 if __name__ == '__main__':
   sys.exit(main())