Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1853433006: Add more type inference uses cases to AST-based summaries. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more type inference uses cases to AST-based summaries. With this CL, we support type inference of fields and property accessors (when generics are not involved) based on inheritance. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5268afc378019c7ec090932fb5fdffecf6ec69ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -163 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 16 chunks +331 lines, -143 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart View 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-01 16:05:42 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-01 16:19:02 UTC) #3
Paul Berry
4 years, 8 months ago (2016-04-01 16:44:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5268afc378019c7ec090932fb5fdffecf6ec69ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698