Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1853433003: Remove harmony flag for travis runs (Closed)

Created:
4 years, 8 months ago by vsm
Modified:
4 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove harmony flag for travis runs This appears to trigger our generator breakage. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/75b5d2bcd6bff8c8fb8817dee1977943680ea120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M karma.conf.js View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as 75b5d2bcd6bff8c8fb8817dee1977943680ea120 (presubmit successful).
4 years, 8 months ago (2016-03-31 22:10:21 UTC) #2
Jennifer Messerly
4 years, 8 months ago (2016-04-04 16:29:29 UTC) #3
Message was sent while issue was closed. 
oh wow! Nice find!!! LGTM

Powered by Google App Engine
This is Rietveld 408576698