Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: appengine/logdog/coordinator/backend/archiveCron.go

Issue 1853433002: LogDog: Handle archive failures. (Closed) Base URL: https://github.com/luci/luci-go@logdog-gs-update
Patch Set: Regenerate protobufs. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/logdog/coordinator/endpoints/logs/get_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/logdog/coordinator/backend/archiveCron.go
diff --git a/appengine/logdog/coordinator/backend/archiveCron.go b/appengine/logdog/coordinator/backend/archiveCron.go
index f3b5d79e063b6fa2a1c0435ada4a5c63b51968fd..a7e7f32238bd956239a5636e60b9940280d59e2d 100644
--- a/appengine/logdog/coordinator/backend/archiveCron.go
+++ b/appengine/logdog/coordinator/backend/archiveCron.go
@@ -118,6 +118,10 @@ func (b *Backend) archiveCron(c context.Context, complete bool) error {
now := clock.Now(c).UTC()
q := ds.NewQuery("LogStream")
+ // TODO(dnj): Next schema migration, remove this State constraint in favor
+ // of equality filters on _Terminated and ArchiveState.
+ // It is necessary for now since otherwise, *all* archived streams will match
+ // this query!
var threshold time.Duration
if complete {
threshold = cfg.GetCoordinator().ArchiveDelay.Duration()
« no previous file with comments | « no previous file | appengine/logdog/coordinator/endpoints/logs/get_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698