Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 185343002: DM: fix -w/-r problems stemming from PM/UPM conversions. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

DM: fix -w/-r problems stemming from PM/UPM conversions. DM will now read and write a custom image format, which begins first with a normal PNG, but also includes the bitmap's raw pixels. Most tools (file browser, Preview, Chrome, Skia image decoder) will read the file as PNG. DM skips the encoded PNG and reads the raw pixels instead. This scheme allows perfect pixel comparisons that never go through PM -> UPM or UPM -> PM conversions, as long as you compare on a machine with the same native pixel format as the machine which generated the images. Since we've only ever used this to do same-machine comparisons, that's more than good enough for now. We could convert as needed to a standardized PM pixel format if we find we want these files to be portable. DM -w output now does increase to ~1.3G. If that turns out to be annoyingly big, I'm sure I can come up with a simple pixelwise RLE instead of writing uncompressed pixels. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13638

Patch Set 1 #

Patch Set 2 : notes and errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -55 lines) Patch
M dm/DMWriteTask.cpp View 1 5 chunks +56 lines, -55 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein_C
6 years, 9 months ago (2014-03-01 14:58:58 UTC) #1
reed1
lgtm age-old-question: does WebP support native premul, so we could use it for perfect in/out?
6 years, 9 months ago (2014-03-03 14:05:00 UTC) #2
mtklein
On 2014/03/03 14:05:00, reed1 wrote: > lgtm > > age-old-question: does WebP support native premul, ...
6 years, 9 months ago (2014-03-03 14:41:17 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-03 14:58:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/185343002/20001
6 years, 9 months ago (2014-03-03 14:58:22 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 15:43:57 UTC) #6
Message was sent while issue was closed.
Change committed as 13638

Powered by Google App Engine
This is Rietveld 408576698