Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1853423003: Fix incorrect blink_gc memory dump caused by r383965 (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect blink_gc memory dump caused by r383965 BUG=600574 Committed: https://crrev.com/ff17b14213cf7b5e348d230305e458e1d1f22a18 Cr-Commit-Position: refs/heads/master@{#385120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
keishi
I forgot to reset the heap counters in ProcessHeap.
4 years, 8 months ago (2016-04-05 05:43:59 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-05 05:44:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853423003/1
4 years, 8 months ago (2016-04-05 05:44:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 06:56:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853423003/1
4 years, 8 months ago (2016-04-05 07:20:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 07:27:45 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 07:29:19 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ff17b14213cf7b5e348d230305e458e1d1f22a18
Cr-Commit-Position: refs/heads/master@{#385120}

Powered by Google App Engine
This is Rietveld 408576698