Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1853423002: Fix authutil call (Closed)

Created:
4 years, 8 months ago by martiniss
Modified:
4 years, 8 months ago
Reviewers:
estaab, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Expectations. #

Patch Set 3 : Whoops double call. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M scripts/slave/recipes/infra/recipe_roll_tryjob.py View 1 2 2 chunks +11 lines, -3 lines 0 comments Download
M scripts/slave/recipes/infra/recipe_roll_tryjob.expected/bad_patches.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/infra/recipe_roll_tryjob.expected/basic.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/infra/recipe_roll_tryjob.expected/deps.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/infra/recipe_roll_tryjob.expected/one_patch.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/infra/recipe_roll_tryjob.expected/tryjob.json View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
martiniss
PTAL
4 years, 8 months ago (2016-04-04 23:37:29 UTC) #2
estaab
lgtm
4 years, 8 months ago (2016-04-05 00:45:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853423002/1
4 years, 8 months ago (2016-04-05 00:57:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3546)
4 years, 8 months ago (2016-04-05 01:05:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853423002/40001
4 years, 8 months ago (2016-04-05 01:08:47 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 01:12:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299691

Powered by Google App Engine
This is Rietveld 408576698