Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3856)

Unified Diff: chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc

Issue 1853413002: MD Settings: Convert reset_page/ to use browser proxy pattern. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc b/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc
index b87e8cfcad76b7071a69c19afa36e466cbb0aed7..1c2908c8b0432dddd4a2fb7868da610806f980b3 100644
--- a/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc
+++ b/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc
@@ -86,13 +86,18 @@ class ResetSettingsHandlerTest : public testing::Test {
TEST_F(ResetSettingsHandlerTest, HandleResetProfileSettings) {
base::ListValue list;
+ std::string expected_callback_id("dummyCallbackId");
+ list.AppendString(expected_callback_id);
list.AppendBoolean(false);
handler()->HandleResetProfileSettings(&list);
// Check that the delegate ProfileResetter was called.
EXPECT_EQ(1u, handler()->resets());
// Check that Javascript side is notified after resetting is done.
- EXPECT_EQ("SettingsResetPage.doneResetting",
+ EXPECT_EQ("cr.webUIResponse",
web_ui()->call_data()[0]->function_name());
+ std::string callback_id;
+ EXPECT_TRUE(web_ui()->call_data()[0]->arg1()->GetAsString(&callback_id));
+ EXPECT_EQ(expected_callback_id, callback_id);
}
} // namespace
« no previous file with comments | « chrome/browser/ui/webui/settings/reset_settings_handler.cc ('k') | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698