Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2974)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

Issue 1853413002: MD Settings: Convert reset_page/ to use browser proxy pattern. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
index 0bcc9ba470821e0aa7ba1d47e9153e149d003c01..2d57d12fbc26271870c6491a1709f619d9f7a205 100644
--- a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
+++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
@@ -10,41 +10,31 @@
Polymer({
is: 'settings-reset-profile-dialog',
+ behaviors: [WebUIListenerBehavior],
+
properties: {
feedbackInfo_: String,
},
- /** @override */
- attached: function() {
- cr.define('SettingsResetPage', function() {
- return {
- doneResetting: function() {
- this.$.resetSpinner.active = false;
- this.$.dialog.close();
- this.dispatchResetDoneEvent();
- }.bind(this),
-
- setFeedbackInfo: function(data) {
- this.set('feedbackInfo_', data.feedbackInfo);
- }.bind(this),
- };
- }.bind(this));
- },
+ /** @private {!settings.ResetBrowserProxy} */
+ browserProxy_: null,
/** @override */
ready: function() {
+ this.browserProxy_ = settings.ResetBrowserProxyImpl.getInstance();
+
this.addEventListener('iron-overlay-canceled', function() {
- chrome.send('onHideResetProfileDialog');
- });
- },
+ this.browserProxy_.onHideResetProfileDialog();
+ }.bind(this));
- dispatchResetDoneEvent: function() {
- this.dispatchEvent(new CustomEvent('reset-done'));
+ this.addWebUIListener('feedback-info-changed', function(feedbackInfo) {
+ this.feedbackInfo_ = feedbackInfo;
+ }.bind(this));
},
open: function() {
this.$.dialog.open();
- chrome.send('onShowResetProfileDialog');
+ this.browserProxy_.onShowResetProfileDialog();
},
/** @private */
@@ -55,7 +45,12 @@ Polymer({
/** @private */
onResetTap_: function() {
this.$.resetSpinner.active = true;
- chrome.send('performResetProfileSettings', [this.$.sendSettings.checked]);
+ this.browserProxy_.performResetProfileSettings(
+ this.$.sendSettings.checked).then(function() {
+ this.$.resetSpinner.active = false;
+ this.$.dialog.close();
+ this.dispatchEvent(new CustomEvent('reset-done'));
+ }.bind(this));
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698