MD Settings: Convert reset_page/ to use browser proxy pattern.

chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-reset-profile-dialog' is the dialog shown for clearing profile
  * settings.
  */
 Polymer({
   is: 'settings-reset-profile-dialog',
 
+  behaviors: [WebUIListenerBehavior],
+
   properties: {
     feedbackInfo_: String,
   },
 
+  /** @private {!settings.ResetBrowserProxy} */
+  browserProxy_: null,

[tommycli, 2016/04/05 18:46:28]

I thought private members were still supposed to be under properties (for
clarity despite the performance hit)? Did that change while I was gone?

[dpapad, 2016/04/05 19:23:12]

The debate was not exactly about private VS public but about members used by
HTML markup VS members only used in JS. The conclusion that I remember was that
there is no need for a hard rule, and either is fine (for example see another
such occurrence at
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...).

+
   /** @override */
-  attached: function() {
-    cr.define('SettingsResetPage', function() {
-      return {
-        doneResetting: function() {
-          this.$.resetSpinner.active = false;
-          this.$.dialog.close();
-          this.dispatchResetDoneEvent();
-        }.bind(this),
+  ready: function() {
+    this.browserProxy_ = settings.ResetBrowserProxyImpl.getInstance();
 
-        setFeedbackInfo: function(data) {
-          this.set('feedbackInfo_', data.feedbackInfo);
-        }.bind(this),
-      };
+    this.addEventListener('iron-overlay-canceled', function() {
+      this.browserProxy_.onHideResetProfileDialog();
+    }.bind(this));
+
+    this.addWebUIListener('feedback-info-changed', function(feedbackInfo) {
+      this.set('feedbackInfo_', feedbackInfo);

[tommycli, 2016/04/05 18:46:28]

nit:Is the .set usage necessary for first-level properties?

[dpapad, 2016/04/05 19:23:12]

Done, it was not necessary.

     }.bind(this));
   },
 
-  /** @override */
-  ready: function() {
-    this.addEventListener('iron-overlay-canceled', function() {
-      chrome.send('onHideResetProfileDialog');
-    });
-  },
-
   dispatchResetDoneEvent: function() {

[tommycli, 2016/04/05 18:46:28]

nit: It looks like this method is only non-inlined for test code? May not be
worth it... I tend to favor simple production code with the more complicated
test. just a nit

[dpapad, 2016/04/05 19:23:12]

Done.

     this.dispatchEvent(new CustomEvent('reset-done'));
   },
 
   open: function() {
     this.$.dialog.open();
-    chrome.send('onShowResetProfileDialog');
+    this.browserProxy_.onShowResetProfileDialog();
   },
 
   /** @private */
   onCancelTap_: function() {
     this.$.dialog.cancel();
   },
 
   /** @private */
   onResetTap_: function() {
     this.$.resetSpinner.active = true;
-    chrome.send('performResetProfileSettings', [this.$.sendSettings.checked]);
+    this.browserProxy_.performResetProfileSettings(
+        this.$.sendSettings.checked).then(function() {
+      this.$.resetSpinner.active = false;
+      this.$.dialog.close();
+      this.dispatchResetDoneEvent();
+    }.bind(this));
   },
 
   /** @private */
   onSendSettingsChange_: function() {
     // TODO(dpapad): Update how settings info is surfaced when final mocks
     // exist.
     this.$.settings.hidden = !this.$.sendSettings.checked;
     this.$.dialog.center();
   },
 });