Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1853373004: Keyed IC cleanup: we always return Handle<Code>(), so just return void instead. (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Keyed IC cleanup: we always return Handle<Code>(), so just return void instead. BUG= Committed: https://crrev.com/a6882e82626775a6bc2b6305d3e216514fcc752a Cr-Commit-Position: refs/heads/master@{#35299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -53 lines) Patch
M src/ic/ic.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 17 chunks +31 lines, -50 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-06 12:56:40 UTC) #2
mvstanton
lgtm
4 years, 8 months ago (2016-04-06 12:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853373004/1
4 years, 8 months ago (2016-04-06 12:59:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 13:26:17 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 13:28:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6882e82626775a6bc2b6305d3e216514fcc752a
Cr-Commit-Position: refs/heads/master@{#35299}

Powered by Google App Engine
This is Rietveld 408576698