Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1853373002: Revert of Temporarily disable all calls of CGS private APIs. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporarily disable all calls of CGS private APIs. (patchset #2 id:20001 of https://codereview.chromium.org/1817233002/ ) Reason for revert: Still seeing Window Server crashes: https://bugs.chromium.org/p/chromium/issues/detail?id=515627#c90 Original issue's description: > Temporarily disable all calls of CGS private APIs. > > This will allow us to confirm whether they are responsible for Window Server > crashes on VMs. > > BUG=515627 > > Committed: https://crrev.com/c78367235e513da2c1745785e93c1d085a07de9f > Cr-Commit-Position: refs/heads/master@{#382415} TBR=tapted@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=515627 Committed: https://crrev.com/0a4fda3dfe07cbba5cd71d93b85e43dcf8a7f97f Cr-Commit-Position: refs/heads/master@{#385042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -84 lines) Patch
M ui/base/cocoa/constrained_window/constrained_window_animation.mm View 2 chunks +72 lines, -78 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
erikchen
Created Revert of Temporarily disable all calls of CGS private APIs.
4 years, 8 months ago (2016-04-04 21:44:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853373002/1
4 years, 8 months ago (2016-04-04 21:45:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853373002/1
4 years, 8 months ago (2016-04-04 22:01:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853373002/1
4 years, 8 months ago (2016-04-04 22:31:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853373002/1
4 years, 8 months ago (2016-04-04 23:01:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 23:08:41 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0a4fda3dfe07cbba5cd71d93b85e43dcf8a7f97f Cr-Commit-Position: refs/heads/master@{#385042}
4 years, 8 months ago (2016-04-04 23:10:14 UTC) #9
tapted
4 years, 8 months ago (2016-04-05 00:01:44 UTC) #10
Message was sent while issue was closed.
lgtm - thanks. guess I should update my nickname too.

Random stab-in-the-dark: I wonder whether this could be some fullscreen thingo.

"Stuff changed" for this since 10.9, so maybe Apple introduced a bug. And
although there shouldn't be too many browser_tests tickling fullscreen since it
leads to flakes - we did see code paths (like modifying NSWindow styleMask) that
could start a fullscreen transition when it previously didn't. And because of
the way tests are retried after colliding with concurrency, unless there's a ton
of fullscreen tests, they don't usually get marked as flakes. [like, maybe now
instead of flaking they turn into window server crashes o_O].

Even as hunches go, this one is pretty weak. But it shouldn't be too hard to
swizzle out the fullscreen methods for all browser_tests with the faker we're
using in views_unittests. Then "see what happens".  (the annoying part could be
obscure codepaths the faker doesn't fully fake that would cause test failures).

Powered by Google App Engine
This is Rietveld 408576698