Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1853353002: Use ChromeVox Compat for media router. (Closed)

Created:
4 years, 8 months ago by David Tseng
Modified:
4 years, 8 months ago
Reviewers:
dmazzoni, apacible
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ChromeVox Compat for media router. BUG=597974 Committed: https://crrev.com/1383e326dba3616a7fbbf3ffb865c0eb9180a878 Cr-Commit-Position: refs/heads/master@{#385208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
apacible
non-owner lgtm, thank you! :) I've also added our bug to this issue.
4 years, 8 months ago (2016-04-04 21:08:30 UTC) #4
David Tseng
4 years, 8 months ago (2016-04-05 16:42:47 UTC) #6
dmazzoni
lgtm
4 years, 8 months ago (2016-04-05 16:43:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853353002/1
4 years, 8 months ago (2016-04-05 16:54:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 17:27:46 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:28:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1383e326dba3616a7fbbf3ffb865c0eb9180a878
Cr-Commit-Position: refs/heads/master@{#385208}

Powered by Google App Engine
This is Rietveld 408576698