Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: content/child/blob_storage/blob_transport_controller.h

Issue 1853333003: [BlobAsync] Faster shortcuttin, make renderer controller leaky & alive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/blob_storage/blob_transport_controller.h
diff --git a/content/child/blob_storage/blob_transport_controller.h b/content/child/blob_storage/blob_transport_controller.h
index f2699abddfff96a766e8f7c916a10fc9336954c3..77a8bb915de1303727ff6b8ee8eef4c90af80ae3 100644
--- a/content/child/blob_storage/blob_transport_controller.h
+++ b/content/child/blob_storage/blob_transport_controller.h
@@ -39,6 +39,7 @@ class Sender;
namespace content {
class BlobConsolidation;
+class ThreadSafeSender;
// This class is used to manage all the asynchronous transporation of blobs from
// the Renderer to the Browser process, where it's handling the Renderer side.
@@ -55,14 +56,16 @@ class CONTENT_EXPORT BlobTransportController {
static BlobTransportController* GetInstance();
// This kicks off a blob transfer to the browser thread, which involves
- // sending an IPC message and storing the blob consolidation object.
- // If we have no pending blobs, we also call ChildProcess::AddRefProcess to
- // keep our process around while we transfer. This will be decremented when
- // we finish our last pending transfer (when our map is empty).
- void InitiateBlobTransfer(
+ // sending an IPC message and storing the blob consolidation object. Designed
+ // to be called by the main thread or a worker thread.
+ // This also calls ChildProcess::AddRefProcess to keep our process around
+ // while we transfer.
+ static void InitiateBlobTransfer(
const std::string& uuid,
+ const std::string& content_type,
scoped_ptr<BlobConsolidation> consolidation,
- IPC::Sender* sender,
+ scoped_refptr<ThreadSafeSender> sender,
+ base::SingleThreadTaskRunner* io_runner,
scoped_refptr<base::SingleThreadTaskRunner> main_runner);
// This responds to the request using the sender.
@@ -78,13 +81,10 @@ class CONTENT_EXPORT BlobTransportController {
void OnDone(const std::string& uuid);
-
bool IsTransporting(const std::string& uuid) {
return blob_storage_.find(uuid) != blob_storage_.end();
}
- ~BlobTransportController();
-
private:
friend class BlobTransportControllerTest;
FRIEND_TEST_ALL_PREFIXES(BlobTransportControllerTest, Descriptions);
@@ -92,6 +92,13 @@ class CONTENT_EXPORT BlobTransportController {
FRIEND_TEST_ALL_PREFIXES(BlobTransportControllerTest, SharedMemory);
FRIEND_TEST_ALL_PREFIXES(BlobTransportControllerTest, ResponsesErrors);
+ static void GetDescriptions(BlobConsolidation* consolidation,
+ size_t max_data_population,
+ std::vector<storage::DataElement>* out);
+
+ BlobTransportController();
+ ~BlobTransportController();
+
// Clears all internal state. If our map wasn't previously empty, then we call
// ChildProcess::ReleaseProcess to release our previous reference.
void ClearForTesting();
@@ -103,11 +110,10 @@ class CONTENT_EXPORT BlobTransportController {
};
friend struct base::DefaultLazyInstanceTraits<BlobTransportController>;
- BlobTransportController();
-
- void GetDescriptions(BlobConsolidation* consolidation,
- size_t max_data_population,
- std::vector<storage::DataElement>* out);
+ void StoreBlobDataForRequests(
+ const std::string& uuid,
+ scoped_ptr<BlobConsolidation> consolidation,
+ scoped_refptr<base::SingleThreadTaskRunner> main_runner);
ResponsesStatus GetResponses(
const std::string& uuid,

Powered by Google App Engine
This is Rietveld 408576698