[BlobAsync] Faster shortcuttin, make renderer controller leaky & alive.

content/browser/blob_storage/blob_async_builder_host_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/blob/blob_async_builder_host.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <string.h>
 
@@ skipping 508 matching lines @@
                                    {kBlob1}, &context_));
   EXPECT_EQ(BlobTransportResult::DONE,
             host_.RegisterBlobUUID(kBlob2, kContentType, kContentDisposition,
                                    {kGoodBlob}, &context_));
   EXPECT_EQ(BlobTransportResult::DONE,
             host_.RegisterBlobUUID(kBlob3, kContentType, kContentDisposition,
                                    std::set<std::string>(), &context_));
 
   // The first blob shouldn't be building anymore.
   EXPECT_FALSE(host_.IsBeingBuilt(kBlob1));
-  // Test we get BAD_IPC.
-  std::vector<DataElement> descriptions;
-  AddShortcutMemoryItem(2, &descriptions);
-  DataElement element;
-  element.SetToBlob(kBlob1);
-  descriptions.push_back(element);
-  EXPECT_EQ(BlobTransportResult::BAD_IPC,
-            host_.StartBuildingBlob(
-                kBlob1, descriptions, 2, &context_,
-                base::Bind(&BlobAsyncBuilderHostTest::RequestMemoryCallback,
-                           base::Unretained(this))));
 
   // Try to finish the second one, without a reference to the first.
-  descriptions.clear();
+  std::vector<DataElement> descriptions;
   AddShortcutMemoryItem(2, &descriptions);
   EXPECT_EQ(BlobTransportResult::BAD_IPC,
             host_.StartBuildingBlob(
                 kBlob2, descriptions, 2, &context_,
                 base::Bind(&BlobAsyncBuilderHostTest::RequestMemoryCallback,
                            base::Unretained(this))));
   EXPECT_FALSE(host_.IsBeingBuilt(kBlob2));
 
   // Try to finish the third one with the reference we didn't declare earlier.
   descriptions.clear();
   AddShortcutMemoryItem(2, &descriptions);
+  DataElement element;
   element.SetToBlob(kGoodBlob);
   descriptions.push_back(element);
   EXPECT_EQ(BlobTransportResult::BAD_IPC,
             host_.StartBuildingBlob(
                 kBlob3, descriptions, 2, &context_,
                 base::Bind(&BlobAsyncBuilderHostTest::RequestMemoryCallback,
                            base::Unretained(this))));
   EXPECT_FALSE(host_.IsBeingBuilt(kBlob3));
 };
 
@@ skipping 49 matching lines @@
             host_.RegisterBlobUUID(kBlob1, kContentType, kContentDisposition,
                                    std::set<std::string>(), &context_));
   host_.CancelBuildingBlob(kBlob1, IPCBlobCreationCancelCode::UNKNOWN,
                            &context_);
   EXPECT_EQ(BlobTransportResult::CANCEL_REFERENCED_BLOB_BROKEN,
             host_.RegisterBlobUUID(kBlob2, kContentType, kContentDisposition,
                                    {kBlob1}, &context_));
   EXPECT_FALSE(host_.IsBeingBuilt(kBlob2));
   EXPECT_FALSE(IsBeingBuiltInContext(kBlob2));
   EXPECT_TRUE(context_.GetBlobDataFromUUID(kBlob2)->IsBroken());
-
-  // Try to finish the second one, but we should get a BAD_IPC, as we are no
-  // longer being constructed.
-  std::vector<DataElement> descriptions;
-  AddShortcutMemoryItem(2, &descriptions);
-  DataElement element;
-  element.SetToBlob(kBlob1);
-  descriptions.push_back(element);
-  EXPECT_EQ(BlobTransportResult::BAD_IPC,
-            host_.StartBuildingBlob(
-                kBlob2, descriptions, 2, &context_,
-                base::Bind(&BlobAsyncBuilderHostTest::RequestMemoryCallback,
-                           base::Unretained(this))));
-  EXPECT_FALSE(request_called_);
-  EXPECT_TRUE(context_.GetBlobDataFromUUID(kBlob2)->IsBroken());
 };
 
 }  // namespace storage