Source/devtools/front_end/TimelinePanel.js - Issue 185333002: DevTools: complete the move of UI builders from timeline presentation record to timeline ui uti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/TimelinePanel.js

Issue 185333002: DevTools: complete the move of UI builders from timeline presentation record to timeline ui uti… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/timeline/timeline-node-reference.html ('k') | Source/devtools/front_end/TimelinePresentationModel.js » ('j') | Source/devtools/front_end/TimelineView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/TimelinePanel.js

diff --git a/Source/devtools/front_end/TimelinePanel.js b/Source/devtools/front_end/TimelinePanel.js

index c74257eda5e06e13b89abc69a149aaf2eada051d..27eaab83742e35747908d836cf234973e8d11ff0 100644

--- a/Source/devtools/front_end/TimelinePanel.js

+++ b/Source/devtools/front_end/TimelinePanel.js

@@ -834,7 +834,7 @@ WebInspector.TimelinePanel.prototype = {

this._updateSelectionDetails();

return;

}

- record.generatePopupContent(record, this._detailsLinkifier, showCallback.bind(this));

+ WebInspector.TimelineUIUtils.generatePopupContent.generatePopupContent(record, this._detailsLinkifier, showCallback.bind(this));

caseq 2014/03/03 09:15:35 WebInspector.TimelineUIUtils.generatePopupContent.

pfeldman 2014/03/03 09:35:33 Oops, yes, I had this fixed locally. Sorry :) Don

/**

* @param {!DocumentFragment} element