Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: Source/devtools/front_end/TimelineView.js

Issue 185333002: DevTools: complete the move of UI builders from timeline presentation record to timeline ui uti… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 785 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 * @param {!Element} anchor 796 * @param {!Element} anchor
797 * @param {!WebInspector.Popover} popover 797 * @param {!WebInspector.Popover} popover
798 */ 798 */
799 _showPopover: function(anchor, popover) 799 _showPopover: function(anchor, popover)
800 { 800 {
801 if (anchor.classList.contains("timeline-frame-strip")) { 801 if (anchor.classList.contains("timeline-frame-strip")) {
802 var frame = anchor._frame; 802 var frame = anchor._frame;
803 popover.show(WebInspector.TimelineUIUtils.generatePopupContentForFra me(frame), anchor); 803 popover.show(WebInspector.TimelineUIUtils.generatePopupContentForFra me(frame), anchor);
804 } else { 804 } else {
805 if (anchor.row && anchor.row._record) 805 if (anchor.row && anchor.row._record)
806 anchor.row._record.generatePopupContent(anchor.row._record, this ._linkifier, showCallback); 806 WebInspector.TimelineUIUtils.generatePopupContent.generatePopupC ontent(anchor.row._record, this._linkifier, showCallback);
caseq 2014/03/03 09:15:35 ditto
pfeldman 2014/03/03 09:35:33 Done.
807 else if (anchor._tasksInfo) 807 else if (anchor._tasksInfo)
808 popover.show(WebInspector.TimelineUIUtils.generateMainThreadBarP opupContent(this._model, anchor._tasksInfo), anchor, null, null, WebInspector.Po pover.Orientation.Bottom); 808 popover.show(WebInspector.TimelineUIUtils.generateMainThreadBarP opupContent(this._model, anchor._tasksInfo), anchor, null, null, WebInspector.Po pover.Orientation.Bottom);
809 } 809 }
810 810
811 function showCallback(popupContent) 811 function showCallback(popupContent)
812 { 812 {
813 popover.show(popupContent, anchor); 813 popover.show(popupContent, anchor);
814 } 814 }
815 }, 815 },
816 816
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
1023 this.element.classList.add("background"); 1023 this.element.classList.add("background");
1024 1024
1025 this._typeElement.textContent = record.title(); 1025 this._typeElement.textContent = record.title();
1026 1026
1027 if (this._dataElement.firstChild) 1027 if (this._dataElement.firstChild)
1028 this._dataElement.removeChildren(); 1028 this._dataElement.removeChildren();
1029 1029
1030 this._warningElement.enableStyleClass("hidden", !record.hasWarnings() && !record.childHasWarnings()); 1030 this._warningElement.enableStyleClass("hidden", !record.hasWarnings() && !record.childHasWarnings());
1031 this._warningElement.enableStyleClass("timeline-tree-item-child-warning" , record.childHasWarnings() && !record.hasWarnings()); 1031 this._warningElement.enableStyleClass("timeline-tree-item-child-warning" , record.childHasWarnings() && !record.hasWarnings());
1032 1032
1033 var detailsNode = record.buildDetailsNode(record, this._linkifier); 1033 var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNode(record, this._linkifier);
1034 if (detailsNode) { 1034 if (detailsNode) {
1035 this._dataElement.appendChild(document.createTextNode("(")); 1035 this._dataElement.appendChild(document.createTextNode("("));
1036 this._dataElement.appendChild(detailsNode); 1036 this._dataElement.appendChild(detailsNode);
1037 this._dataElement.appendChild(document.createTextNode(")")); 1037 this._dataElement.appendChild(document.createTextNode(")"));
1038 } 1038 }
1039 this._expandArrowElement.enableStyleClass("parent", record.children && r ecord.children.length); 1039 this._expandArrowElement.enableStyleClass("parent", record.children && r ecord.children.length);
1040 this._expandArrowElement.enableStyleClass("expanded", record.visibleChil drenCount); 1040 this._expandArrowElement.enableStyleClass("expanded", record.visibleChil drenCount);
1041 this._record.setUserObject("WebInspector.TimelineRecordListRow", this); 1041 this._record.setUserObject("WebInspector.TimelineRecordListRow", this);
1042 }, 1042 },
1043 1043
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
1242 this._element.classList.remove("hidden"); 1242 this._element.classList.remove("hidden");
1243 } else 1243 } else
1244 this._element.classList.add("hidden"); 1244 this._element.classList.add("hidden");
1245 }, 1245 },
1246 1246
1247 _dispose: function() 1247 _dispose: function()
1248 { 1248 {
1249 this._element.remove(); 1249 this._element.remove();
1250 } 1250 }
1251 } 1251 }
OLDNEW
« Source/devtools/front_end/TimelinePanel.js ('K') | « Source/devtools/front_end/TimelineUIUtils.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698