Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 18533: Merge r5767 - Protect cookie headers from XHR... (Closed)

Created:
11 years, 11 months ago by laforge
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge r5767 - Protect cookie headers from XHR Add a flags to further control response header persistence. We use this to filter out Set-Cookie and Set-Cookie2 response headers from being forwarded to the renderer. This serves to prevent the renderer from having any access to HttpOnly cookies, and it also prevents XMLHttpRequest consumers from being able to read cookies in the HTTP response headers. This is consistent with changes made to Firefox and WebKit. Patch by marius.schilder@gmail.com R=deanm,darin Review URL: http://codereview.chromium.org/11264 TBR=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -61 lines) Patch
M chrome/common/render_messages.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/http/http_cache.cc View 1 chunk +12 lines, -1 line 0 comments Download
M net/http/http_response_headers.h View 2 chunks +26 lines, -8 lines 0 comments Download
M net/http/http_response_headers.cc View 4 chunks +72 lines, -37 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 12 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 11 months ago (2009-01-23 00:50:11 UTC) #1
darin (slow to review)
11 years, 11 months ago (2009-01-23 00:52:56 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698