Issue 1853273002: Don't use async/await for Pool.withResource().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1853273002: Don't use async/await for Pool.withResource(). (Closed)

Created:
4 years, 8 months ago by nweiz

Modified:
4 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pool@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use async/await for Pool.withResource(). The async gap introduces a potential race condition. Closes #3 R=rnystrom@google.com Committed: https://github.com/dart-lang/pool/commit/91ea1d160c753ff72eaf81964d12aa749a641ddb

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -9 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/pool.dart	View	1 chunk	+8 lines, -7 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/pool_test.dart	View	2 chunks	+8 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Bob Nystrom

LGTM. Sigh, it was only a matter time before we got burned by this.

4 years, 8 months ago (2016-04-04 21:53:58 UTC) #2

nweiz

4 years, 8 months ago (2016-04-04 22:44:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
91ea1d160c753ff72eaf81964d12aa749a641ddb (presubmit successful).