Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(68)

Issue 1853273002: Don't use async/await for Pool.withResource(). (Closed)

Created:
3 years, 9 months ago by nweiz
Modified:
3 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pool@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use async/await for Pool.withResource(). The async gap introduces a potential race condition. Closes #3 R=rnystrom@google.com Committed: https://github.com/dart-lang/pool/commit/91ea1d160c753ff72eaf81964d12aa749a641ddb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/pool.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/pool_test.dart View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
3 years, 9 months ago (2016-04-04 19:29:35 UTC) #1
Bob Nystrom
LGTM. Sigh, it was only a matter time before we got burned by this.
3 years, 9 months ago (2016-04-04 21:53:58 UTC) #2
nweiz
3 years, 9 months ago (2016-04-04 22:44:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91ea1d160c753ff72eaf81964d12aa749a641ddb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698