Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1853263002: Replace free isnan with std::isnan (Closed)

Created:
4 years, 8 months ago by robwu
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace free isnan with std::isnan isnan from cmath is not a free function, but part of the std namespace. This worked before, but was changed in in glibc 2.23 https://sourceware.org/bugzilla/show_bug.cgi?id=19439. BUG=595429 TEST=Chrome compiles with glibc 2.23 Committed: https://crrev.com/f46ba822df322dc98315eba4493382dc80bfc1c5 Cr-Commit-Position: refs/heads/master@{#385134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/engagement/site_engagement_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
robwu
Regarding https://codereview.chromium.org/1758573002#msg11 > https://chromium-cpp.appspot.com/ mentions <cmath> instead of <math.h>, don't really know the difference myself... ...
4 years, 8 months ago (2016-04-04 20:23:32 UTC) #2
Dan Beam
lgtm
4 years, 8 months ago (2016-04-04 23:57:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853263002/1
4 years, 8 months ago (2016-04-05 08:33:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 08:37:54 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 08:39:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f46ba822df322dc98315eba4493382dc80bfc1c5
Cr-Commit-Position: refs/heads/master@{#385134}

Powered by Google App Engine
This is Rietveld 408576698