xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Better argument type for CFX_BinaryBuf::AppendString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp

diff --git a/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp b/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp

index 5f8a0c25aa776c2fa2865f395bc96787e245c5e2..f767ffa16949e655a7ede82145fd0bef316147ba 100644

--- a/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp

+++ b/xfa/fxbarcode/oned/BC_OnedCodaBarReader.cpp

@@ -106,7 +106,8 @@ CFX_ByteString CBC_OnedCodaBarReader::DecodeRow(int32_t rowNumber,

}

if (result.GetLength() < 5) {

- int32_t index = temp.Find(result.Mid(1, result.GetLength() - 1));

+ int32_t index =

+ temp.Find(result.Mid(1, result.GetLength() - 1).AsByteStringC());

if (index == len - (result.GetLength() - 1)) {

e = BCExceptionNotFound;

return "";

« core/fpdfdoc/doc_form.cpp ('K') | « xfa/fwl/basewidget/fwl_editimp.cpp ('k') | xfa/fxfa/app/xfa_checksum.cpp » ('j') | no next file with comments »