fpdfsdk/fpdf_ext.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdf_ext.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Better argument type for CFX_BinaryBuf::AppendString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/fpdf_ext.cpp

diff --git a/fpdfsdk/fpdf_ext.cpp b/fpdfsdk/fpdf_ext.cpp

index 484993c6a1db99e9294cef3dcdc71d495443b3cf..a1009c5cdf4cceff895e32f6d5b2c9f6660857b5 100644

--- a/fpdfsdk/fpdf_ext.cpp

+++ b/fpdfsdk/fpdf_ext.cpp

@@ -104,10 +104,11 @@ FX_BOOL CheckSharedForm(const CXML_Element* pElement, CFX_ByteString cbName) {

pElement->GetAttrByIndex(i, space, name, value);

if (space == "xmlns" && name == "adhocwf" &&

value == L"http://ns.adobe.com/AcrobatAdhocWorkflow/1.0/") {

- CXML_Element* pVersion = pElement->GetElement("adhocwf", cbName);

+ CXML_Element* pVersion =

+ pElement->GetElement("adhocwf", cbName.AsByteStringC());

if (!pVersion)

continue;

- CFX_WideString wsContent = pVersion->GetContent(0); // == 1.1

+ CFX_WideString wsContent = pVersion->GetContent(0);

int nType = wsContent.GetInteger();

switch (nType) {

case 1:

« core/fpdfdoc/doc_form.cpp ('K') | « fpdfsdk/formfiller/cba_fontmap.cpp ('k') | fpdfsdk/fpdf_flatten.cpp » ('j') | no next file with comments »