core/fpdfdoc/doc_formfield.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_formfield.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Better argument type for CFX_BinaryBuf::AppendString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfdoc/doc_formfield.cpp

diff --git a/core/fpdfdoc/doc_formfield.cpp b/core/fpdfdoc/doc_formfield.cpp

index 0f8b3dd5eab7ec7060997f7cd39b46332ec45c48..931f9e18d93ebc9ca902fbaa571031d606b20626 100644

--- a/core/fpdfdoc/doc_formfield.cpp

+++ b/core/fpdfdoc/doc_formfield.cpp

@@ -1054,7 +1054,7 @@ void CPDF_FormField::LoadDA() {

if (DA.IsEmpty()) {

return;

}

- CPDF_SimpleParser syntax(DA);

+ CPDF_SimpleParser syntax(DA.AsByteStringC());

syntax.FindTagParamFromStart("Tf", 2);

CFX_ByteString font_name = syntax.GetWord();

CPDF_Dictionary* pFontDict = NULL;

@@ -1062,7 +1062,7 @@ void CPDF_FormField::LoadDA() {

m_pForm->m_pFormDict->GetDictBy("DR")->GetDictBy("Font"))

pFontDict = m_pForm->m_pFormDict->GetDictBy("DR")

->GetDictBy("Font")

- ->GetDictBy(font_name);

+ ->GetDictBy(font_name.AsByteStringC());

if (!pFontDict) {

return;

« core/fpdfdoc/doc_form.cpp ('K') | « core/fpdfdoc/doc_formcontrol.cpp ('k') | core/fpdfdoc/doc_link.cpp » ('j') | no next file with comments »