core/fpdfapi/fpdf_parser/cpdf_parser.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Better argument type for CFX_BinaryBuf::AppendString() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp ('k') | core/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp » ('j') | core/fpdfdoc/doc_form.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

index 305401525ce62ed28b27d020d5bb4a2e240a1a14..73ca71ef1a0ade19efa5fd954e3363ed22b2bb15 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

@@ -822,10 +822,11 @@ FX_BOOL CPDF_Parser::RebuildCrossRef() {

uint32_t dwObjNum =

pElement ? pElement->GetObjNum() : 0;

if (dwObjNum) {

- m_pTrailer->SetAtReference(key, m_pDocument,

- dwObjNum);

+ m_pTrailer->SetAtReference(key.AsByteStringC(),

+ m_pDocument, dwObjNum);

} else {

- m_pTrailer->SetAt(key, pElement->Clone());

+ m_pTrailer->SetAt(key.AsByteStringC(),

+ pElement->Clone());

}