Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: core/fxcrt/fxcrt_posix.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fxcrt/fx_xml_parser.cpp ('k') | core/fxcrt/include/fx_basic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fxcrt/fxcrt_posix.h" 7 #include "core/fxcrt/fxcrt_posix.h"
8 8
9 #include "core/fxcrt/include/fx_basic.h" 9 #include "core/fxcrt/include/fx_basic.h"
10 10
(...skipping 27 matching lines...) Expand all
38 if (m_nFD > -1) { 38 if (m_nFD > -1) {
39 return FALSE; 39 return FALSE;
40 } 40 }
41 int32_t nFlags, nMasks; 41 int32_t nFlags, nMasks;
42 FXCRT_Posix_GetFileMode(dwMode, nFlags, nMasks); 42 FXCRT_Posix_GetFileMode(dwMode, nFlags, nMasks);
43 m_nFD = open(fileName.GetCStr(), nFlags, nMasks); 43 m_nFD = open(fileName.GetCStr(), nFlags, nMasks);
44 return m_nFD > -1; 44 return m_nFD > -1;
45 } 45 }
46 FX_BOOL CFXCRT_FileAccess_Posix::Open(const CFX_WideStringC& fileName, 46 FX_BOOL CFXCRT_FileAccess_Posix::Open(const CFX_WideStringC& fileName,
47 uint32_t dwMode) { 47 uint32_t dwMode) {
48 return Open(FX_UTF8Encode(fileName), dwMode); 48 return Open(FX_UTF8Encode(fileName).AsByteStringC(), dwMode);
49 } 49 }
50 void CFXCRT_FileAccess_Posix::Close() { 50 void CFXCRT_FileAccess_Posix::Close() {
51 if (m_nFD < 0) { 51 if (m_nFD < 0) {
52 return; 52 return;
53 } 53 }
54 close(m_nFD); 54 close(m_nFD);
55 m_nFD = -1; 55 m_nFD = -1;
56 } 56 }
57 void CFXCRT_FileAccess_Posix::Release() { 57 void CFXCRT_FileAccess_Posix::Release() {
58 delete this; 58 delete this;
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 } 121 }
122 return fsync(m_nFD) > -1; 122 return fsync(m_nFD) > -1;
123 } 123 }
124 FX_BOOL CFXCRT_FileAccess_Posix::Truncate(FX_FILESIZE szFile) { 124 FX_BOOL CFXCRT_FileAccess_Posix::Truncate(FX_FILESIZE szFile) {
125 if (m_nFD < 0) { 125 if (m_nFD < 0) {
126 return FALSE; 126 return FALSE;
127 } 127 }
128 return !ftruncate(m_nFD, szFile); 128 return !ftruncate(m_nFD, szFile);
129 } 129 }
130 #endif 130 #endif
OLDNEW
« no previous file with comments | « core/fxcrt/fx_xml_parser.cpp ('k') | core/fxcrt/include/fx_basic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698