Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: core/fpdfdoc/doc_link.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Fix CPDF_Name::GetConstString() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfdoc/doc_formfield.cpp ('k') | core/fpdfdoc/doc_ocg.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/include/fpdfdoc/fpdf_doc.h" 7 #include "core/include/fpdfdoc/fpdf_doc.h"
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 CFX_FloatRect CPDF_Link::GetRect() { 74 CFX_FloatRect CPDF_Link::GetRect() {
75 return m_pDict->GetRectBy("Rect"); 75 return m_pDict->GetRectBy("Rect");
76 } 76 }
77 CPDF_Dest CPDF_Link::GetDest(CPDF_Document* pDoc) { 77 CPDF_Dest CPDF_Link::GetDest(CPDF_Document* pDoc) {
78 CPDF_Object* pDest = m_pDict->GetDirectObjectBy("Dest"); 78 CPDF_Object* pDest = m_pDict->GetDirectObjectBy("Dest");
79 if (!pDest) 79 if (!pDest)
80 return CPDF_Dest(); 80 return CPDF_Dest();
81 81
82 if (pDest->IsString() || pDest->IsName()) { 82 if (pDest->IsString() || pDest->IsName()) {
83 CPDF_NameTree name_tree(pDoc, "Dests"); 83 CPDF_NameTree name_tree(pDoc, "Dests");
84 CFX_ByteStringC name = pDest->GetString(); 84 return CPDF_Dest(
85 return CPDF_Dest(name_tree.LookupNamedDest(pDoc, name)); 85 name_tree.LookupNamedDest(pDoc, pDest->GetString().AsByteStringC()));
86 } 86 }
87 if (CPDF_Array* pArray = pDest->AsArray()) 87 if (CPDF_Array* pArray = pDest->AsArray())
88 return CPDF_Dest(pArray); 88 return CPDF_Dest(pArray);
89 return CPDF_Dest(); 89 return CPDF_Dest();
90 } 90 }
91 CPDF_Action CPDF_Link::GetAction() { 91 CPDF_Action CPDF_Link::GetAction() {
92 return CPDF_Action(m_pDict->GetDictBy("A")); 92 return CPDF_Action(m_pDict->GetDictBy("A"));
93 } 93 }
OLDNEW
« no previous file with comments | « core/fpdfdoc/doc_formfield.cpp ('k') | core/fpdfdoc/doc_ocg.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698