Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_edit/editint.h"
 
 #include <vector>
 
@@ skipping 36 matching lines @@
       if (pFile->AppendString(" null") < 0) {
         return -1;
       }
       offset += 5;
       break;
     case CPDF_Object::BOOLEAN:
     case CPDF_Object::NUMBER:
       if (pFile->AppendString(" ") < 0) {
         return -1;
       }
-      if ((len = pFile->AppendString(pObj->GetString())) < 0) {
+      if ((len = pFile->AppendString(pObj->GetString().AsByteStringC())) < 0) {
         return -1;
       }
       offset += len + 1;
       break;
     case CPDF_Object::STRING: {
       CFX_ByteString str = pObj->GetString();
       FX_BOOL bHex = pObj->AsString()->IsHex();
-      if ((len = pFile->AppendString(PDF_EncodeString(str, bHex))) < 0) {
+      if ((len = pFile->AppendString(
+               PDF_EncodeString(str, bHex).AsByteStringC())) < 0) {
         return -1;
       }
       offset += len;
       break;
     }
     case CPDF_Object::NAME: {
       if (pFile->AppendString("/") < 0) {
         return -1;
       }
       CFX_ByteString str = pObj->GetString();
-      if ((len = pFile->AppendString(PDF_NameEncode(str))) < 0) {
+      if ((len = pFile->AppendString(PDF_NameEncode(str).AsByteStringC())) <
+          0) {
         return -1;
       }
       offset += len + 1;
       break;
     }
     case CPDF_Object::REFERENCE: {
       if (pFile->AppendString(" ") < 0)
         return -1;
       if ((len = pFile->AppendDWord(pObj->AsReference()->GetRefObjNum())) < 0)
         return -1;
@@ skipping 38 matching lines @@
         return -1;
       }
       offset += 2;
       const CPDF_Dictionary* p = pObj->AsDictionary();
       for (const auto& it : *p) {
         const CFX_ByteString& key = it.first;
         CPDF_Object* pValue = it.second;
         if (pFile->AppendString("/") < 0) {
           return -1;
         }
-        if ((len = pFile->AppendString(PDF_NameEncode(key))) < 0) {
+        if ((len = pFile->AppendString(PDF_NameEncode(key).AsByteStringC())) <
+            0) {
           return -1;
         }
         offset += len + 1;
         if (pValue->GetObjNum()) {
           if (pFile->AppendString(" ") < 0) {
             return -1;
           }
           if ((len = pFile->AppendDWord(pValue->GetObjNum())) < 0) {
             return -1;
           }
@@ skipping 58 matching lines @@
           key == "Index" || key == "Length" || key == "Prev" || key == "W" ||
           key == "XRefStm" || key == "Type" || key == "ID") {
         continue;
       }
       if (bCompress && key == "DecodeParms") {
         continue;
       }
       if (pFile->AppendString(("/")) < 0) {
         return -1;
       }
-      if ((len = pFile->AppendString(PDF_NameEncode(key))) < 0) {
+      if ((len = pFile->AppendString(PDF_NameEncode(key).AsByteStringC())) <
+          0) {
         return -1;
       }
       offset += len + 1;
       if (pValue->GetObjNum()) {
         if (pFile->AppendString(" ") < 0) {
           return -1;
         }
         if ((len = pFile->AppendDWord(pValue->GetObjNum())) < 0) {
           return -1;
         }
@@ skipping 882 matching lines @@
       if (m_File.AppendString(" null") < 0) {
         return -1;
       }
       m_Offset += 5;
       break;
     case CPDF_Object::BOOLEAN:
     case CPDF_Object::NUMBER:
       if (m_File.AppendString(" ") < 0) {
         return -1;
       }
-      if ((len = m_File.AppendString(pObj->GetString())) < 0) {
+      if ((len = m_File.AppendString(pObj->GetString().AsByteStringC())) < 0) {
         return -1;
       }
       m_Offset += len + 1;
       break;
     case CPDF_Object::STRING: {
       CFX_ByteString str = pObj->GetString();
       FX_BOOL bHex = pObj->AsString()->IsHex();
       if (!m_pCryptoHandler || !bEncrypt) {
         CFX_ByteString content = PDF_EncodeString(str, bHex);
-        if ((len = m_File.AppendString(content)) < 0) {
+        if ((len = m_File.AppendString(content.AsByteStringC())) < 0) {
           return -1;
         }
         m_Offset += len;
         break;
       }
       CPDF_Encryptor encryptor;
       encryptor.Initialize(m_pCryptoHandler, objnum, (uint8_t*)str.c_str(),
                            str.GetLength());
       CFX_ByteString content = PDF_EncodeString(
           CFX_ByteString((const FX_CHAR*)encryptor.m_pData, encryptor.m_dwSize),
           bHex);
-      if ((len = m_File.AppendString(content)) < 0) {
+      if ((len = m_File.AppendString(content.AsByteStringC())) < 0) {
         return -1;
       }
       m_Offset += len;
       break;
     }
     case CPDF_Object::STREAM: {
       CPDF_FlateEncoder encoder;
       encoder.Initialize(const_cast<CPDF_Stream*>(pObj->AsStream()),
                          m_bCompress);
       CPDF_Encryptor encryptor;
@@ skipping 19 matching lines @@
         return -1;
       }
       m_Offset += len;
       break;
     }
     case CPDF_Object::NAME: {
       if (m_File.AppendString("/") < 0) {
         return -1;
       }
       CFX_ByteString str = pObj->GetString();
-      if ((len = m_File.AppendString(PDF_NameEncode(str))) < 0) {
+      if ((len = m_File.AppendString(PDF_NameEncode(str).AsByteStringC())) <
+          0) {
         return -1;
       }
       m_Offset += len + 1;
       break;
     }
     case CPDF_Object::REFERENCE: {
       if (m_File.AppendString(" ") < 0)
         return -1;
       if ((len = m_File.AppendDWord(pObj->AsReference()->GetRefObjNum())) < 0)
         return -1;
@@ skipping 43 matching lines @@
       m_Offset += 2;
       const CPDF_Dictionary* p = pObj->AsDictionary();
       bool bSignDict = p->IsSignatureDict();
       for (const auto& it : *p) {
         FX_BOOL bSignValue = FALSE;
         const CFX_ByteString& key = it.first;
         CPDF_Object* pValue = it.second;
         if (m_File.AppendString("/") < 0) {
           return -1;
         }
-        if ((len = m_File.AppendString(PDF_NameEncode(key))) < 0) {
+        if ((len = m_File.AppendString(PDF_NameEncode(key).AsByteStringC())) <
+            0) {
           return -1;
         }
         m_Offset += len + 1;
         if (bSignDict && key == "Contents") {
           bSignValue = TRUE;
         }
         if (pValue->GetObjNum()) {
           if (m_File.AppendString(" ") < 0) {
             return -1;
           }
@@ skipping 381 matching lines @@
       m_XrefStart = m_pXRefStream->m_PrevOffset;
       m_iStage = 90;
     } else if ((m_dwFlags & FPDFCREATE_INCREMENTAL) == 0 ||
                !m_pParser->IsXRefStream()) {
       if ((m_dwFlags & FPDFCREATE_INCREMENTAL) == 0 ||
           m_pParser->GetLastXRefOffset() == 0) {
         CFX_ByteString str;
         str = m_ObjectOffset.GetPtrAt(1)
                   ? "xref\r\n"
                   : "xref\r\n0 1\r\n0000000000 65535 f\r\n";
-        if (m_File.AppendString(str) < 0) {
+        if (m_File.AppendString(str.AsByteStringC()) < 0) {
           return -1;
         }
         m_Pos = (void*)(uintptr_t)1;
         m_iStage = 81;
       } else {
         if (m_File.AppendString("xref\r\n") < 0) {
           return -1;
         }
         m_Pos = (void*)(uintptr_t)0;
         m_iStage = 82;
@@ skipping 108 matching lines @@
         // TODO(ochang): Consolidate with similar check in
         // PDF_CreatorWriteTrailer.
         if (key == "Encrypt" || key == "Size" || key == "Filter" ||
             key == "Index" || key == "Length" || key == "Prev" || key == "W" ||
             key == "XRefStm" || key == "ID") {
           continue;
         }
         if (m_File.AppendString(("/")) < 0) {
           return -1;
         }
-        if (m_File.AppendString(PDF_NameEncode(key)) < 0) {
+        if (m_File.AppendString(PDF_NameEncode(key).AsByteStringC()) < 0) {
           return -1;
         }
         if (pValue->GetObjNum()) {
           if (m_File.AppendString(" ") < 0) {
             return -1;
           }
           if (m_File.AppendDWord(pValue->GetObjNum()) < 0) {
             return -1;
           }
           if (m_File.AppendString(" 0 R ") < 0) {
@@ skipping 284 matching lines @@
   m_bNewCrypto = FALSE;
   if (!m_bStandardSecurity) {
     return;
   }
   if (m_pEncryptDict) {
     m_pEncryptDict->Release();
     m_pEncryptDict = NULL;
   }
   m_bStandardSecurity = FALSE;
 }