Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Side by Side Diff: Source/devtools/front_end/TimelinePanel.js

Issue 185323002: DevTools: prepare to move UI builders from timeline presentation record to timeline ui utils. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 816 matching lines...) Expand 10 before | Expand all | Expand 10 after
827 } 827 }
828 828
829 for (var i = 0; i < this._currentViews.length; ++i) { 829 for (var i = 0; i < this._currentViews.length; ++i) {
830 var view = this._currentViews[i]; 830 var view = this._currentViews[i];
831 view.setSelectedRecord(record); 831 view.setSelectedRecord(record);
832 } 832 }
833 if (!record) { 833 if (!record) {
834 this._updateSelectionDetails(); 834 this._updateSelectionDetails();
835 return; 835 return;
836 } 836 }
837 record.generatePopupContent(this._detailsLinkifier, showCallback.bind(th is)); 837 record.generatePopupContent(record, this._detailsLinkifier, showCallback .bind(this));
838 838
839 /** 839 /**
840 * @param {!DocumentFragment} element 840 * @param {!DocumentFragment} element
841 * @this {WebInspector.TimelinePanel} 841 * @this {WebInspector.TimelinePanel}
842 */ 842 */
843 function showCallback(element) 843 function showCallback(element)
844 { 844 {
845 this._detailsView.setContent(record.title(), element); 845 this._detailsView.setContent(record.title(), element);
846 } 846 }
847 }, 847 },
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
1046 1046
1047 /** 1047 /**
1048 * @param {!WebInspector.TimelinePresentationModel.Record} record 1048 * @param {!WebInspector.TimelinePresentationModel.Record} record
1049 * @return {boolean} 1049 * @return {boolean}
1050 */ 1050 */
1051 accept: function(record) 1051 accept: function(record)
1052 { 1052 {
1053 return record.lastChildEndTime >= this._windowStartTime && record.startT ime <= this._windowEndTime; 1053 return record.lastChildEndTime >= this._windowStartTime && record.startT ime <= this._windowEndTime;
1054 } 1054 }
1055 } 1055 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698