Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1853223002: Reland of move "#pragma comment(lib" in media. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move "#pragma comment(lib" in media. (patchset #1 id:1 of https://codereview.chromium.org/1855183005/ ) Reason for revert: This couldn't have caused the build breakage; that's a missing dependency inside blink. Original issue's description: > Revert of Remove "#pragma comment(lib" in media. (patchset #1 id:1 of https://codereview.chromium.org/1850223002/ ) > > Reason for revert: > Speculatively reverting, hoping that this is the CL to blame for the compile redness in https://build.chromium.org/p/chromium/builders/Win/builds/42017 > > Original issue's description: > > Remove "#pragma comment(lib" in media. > > > > BUG=597028 > > > > Committed: https://crrev.com/e266135aab534260b8f4a2eb956d1f71ab106ae8 > > Cr-Commit-Position: refs/heads/master@{#384928} > > TBR=dalecurtis@chromium.org,tommi@chromium.org,jam@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=597028 > > Committed: https://crrev.com/3709bb1cb5c96dcdfcd18d84ed53034422c5e533 > Cr-Commit-Position: refs/heads/master@{#384935} TBR=dalecurtis@chromium.org,tommi@chromium.org,lukasza@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597028 Committed: https://crrev.com/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13 Cr-Commit-Position: refs/heads/master@{#384936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M media/audio/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/win/wavein_input_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/win/waveout_output_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jam
Created Reland of move "#pragma comment(lib" in media.
4 years, 8 months ago (2016-04-04 17:37:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853223002/1
4 years, 8 months ago (2016-04-04 17:38:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 17:38:54 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 17:40:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13
Cr-Commit-Position: refs/heads/master@{#384936}

Powered by Google App Engine
This is Rietveld 408576698