Chromium Code Reviews
DescriptionReland of move "#pragma comment(lib" in media. (patchset #1 id:1 of https://codereview.chromium.org/1855183005/ )
Reason for revert:
This couldn't have caused the build breakage; that's a missing dependency inside blink.
Original issue's description:
> Revert of Remove "#pragma comment(lib" in media. (patchset #1 id:1 of https://codereview.chromium.org/1850223002/ )
>
> Reason for revert:
> Speculatively reverting, hoping that this is the CL to blame for the compile redness in https://build.chromium.org/p/chromium/builders/Win/builds/42017
>
> Original issue's description:
> > Remove "#pragma comment(lib" in media.
> >
> > BUG=597028
> >
> > Committed: https://crrev.com/e266135aab534260b8f4a2eb956d1f71ab106ae8
> > Cr-Commit-Position: refs/heads/master@{#384928}
>
> TBR=dalecurtis@chromium.org,tommi@chromium.org,jam@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=597028
>
> Committed: https://crrev.com/3709bb1cb5c96dcdfcd18d84ed53034422c5e533
> Cr-Commit-Position: refs/heads/master@{#384935}
TBR=dalecurtis@chromium.org,tommi@chromium.org,lukasza@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=597028
Committed: https://crrev.com/4bb1fbb5df886fce9607a8486fb3c01b0fd4dd13
Cr-Commit-Position: refs/heads/master@{#384936}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||