Chromium Code Reviews| Index: pkg/analysis_server/lib/src/protocol.dart |
| diff --git a/pkg/analysis_server/lib/src/protocol.dart b/pkg/analysis_server/lib/src/protocol.dart |
| index 0d39c312dbf0a6811b826d9d7ca1661bf18ae985..d2f926b8c3fdf6d1e1af1dbe2c2fbf882f025698 100644 |
| --- a/pkg/analysis_server/lib/src/protocol.dart |
| +++ b/pkg/analysis_server/lib/src/protocol.dart |
| @@ -265,8 +265,10 @@ class Response { |
| */ |
| factory Response.fromJson(Map<String, Object> json) { |
| try { |
| - // TODO process result |
| String id = json[Response.ID]; |
|
Bob Nystrom
2014/03/04 01:03:45
Embrace the "var". :)
danrubel
2014/03/05 15:32:04
Good point. The value could be any object. I've up
|
| + if (id == null) { |
| + return null; |
| + } |
|
Bob Nystrom
2014/03/04 01:03:45
This is a personal preference, but I'd make this a
danrubel
2014/03/05 15:32:04
I might as well, but I'm trying to be consistent w
|
| var error = json[Response.ERROR]; |
| var result = json[Response.RESULT]; |
| Response response; |