restructure client api to use streams

pkg/analysis_server/lib/src/analysis_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
+
 import 'package:analysis_server/src/channel.dart';
 import 'package:analysis_server/src/domain_server.dart';
 import 'package:analysis_server/src/protocol.dart';
 
 /**
  * [AnalysisManager] is used to launch and manage an analysis server
  * running in a separate process using either the [start] or [connect] methods.
  */
 class AnalysisManager {
   // TODO dynamically allocate port and/or allow client to specify port
@@ skipping 92 matching lines @@
 
   /**
    * Stop the analysis server.
    *
    * Returns `true` if the signal is successfully sent and process terminates.
    * Otherwise there was no attached process or the signal could not be sent,
    * usually meaning that the process is already dead.
    */
   Future<bool> stop() {
     if (process == null) {
+      channel.close();

[Bob Nystrom, 2014/03/04 01:03:45]

This should probably be async too:

return channel.close().then((_) => false);

[danrubel, 2014/03/05 15:32:04]

Good point. Updated close() to return a Future and used it here.

[nweiz, 2014/03/05 20:16:39]

Also below.

[danrubel, 2014/03/11 19:06:09]

Done.

       return new Future.value(false);
     }
-    var request = new Request('0', ServerDomainHandler.SHUTDOWN_METHOD);
-    channel.sendRequest(request);
-    return process.exitCode
-        .timeout(new Duration(seconds: 10))
-        .catchError((error) {
+    return channel
+        .sendRequest(new Request('0', ServerDomainHandler.SHUTDOWN_METHOD))
+        .timeout(new Duration(seconds: 2), onTimeout: () {
+          print('Expected shutdown response');
+        })
+        .then((Response response) {
+          channel.close();
+          return process.exitCode;
+        })
+        .timeout(new Duration(seconds: 2), onTimeout: () {
+          print('Expected server to shutdown');
           process.kill();
-          throw 'Expected server to shutdown';
         })
-        .then((result) {
-          if (result != 0) {
+        .then((int result) {
+          if (result != null && result != 0) {
             exitCode = result;
           }
           return true;
         });

[Bob Nystrom, 2014/03/04 01:03:45]

The logic looks good here, but I would format it like:

    var request = new Request('0', ServerDomainHandler.SHUTDOWN_METHOD);
    var timeout = new Duration(seconds: 2);
    return channel.sendRequest(request).timeout(timeout, onTimeout: () {
      print('Expected shutdown response');
    }).then((response) {
      channel.close();
      return process.exitCode;
    }).timeout(timeout, onTimeout: () {
      print('Expected server to shutdown');
      process.kill();
    }).then((result) {
      if (result != null && result != 0) {
        exitCode = result;
      }
      return true;
    });

[danrubel, 2014/03/05 15:32:04]

I find the wrapped style makes it harder to read the futures chain.

   }
-
 }