Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 1853103005: remove avoid and pixelxor xfermodes (Closed)

Created:
4 years, 8 months ago by reed1
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update factory counts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1406 lines) Patch
D gm/avoidxfermode.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
D gm/avoidxfermode2.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D gm/avoidxfermode3.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
D gm/pixelxorxfermode.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M gm/xfermodes.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M gyp/effects.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
D include/client/android/SkAvoidXfermode.h View 1 chunk +0 lines, -81 lines 0 comments Download
D include/client/android/SkPixelXorXfermode.h View 1 chunk +0 lines, -52 lines 0 comments Download
D src/effects/SkAvoidXfermode.cpp View 1 chunk +0 lines, -544 lines 0 comments Download
D src/effects/SkPixelXorXfermode.cpp View 1 chunk +0 lines, -380 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853103005/1
4 years, 8 months ago (2016-04-04 18:53:44 UTC) #3
reed1
4 years, 8 months ago (2016-04-04 18:53:56 UTC) #5
robertphillips
lgtm
4 years, 8 months ago (2016-04-04 18:57:12 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/2628)
4 years, 8 months ago (2016-04-04 18:59:21 UTC) #8
scroggo
We currently have a breakage in Android (unless it's already been fixed?) because AvoidXfermode's CreateProc ...
4 years, 8 months ago (2016-04-04 19:03:08 UTC) #9
djsollen
lgtm after ag/904262 lands.
4 years, 8 months ago (2016-04-04 19:46:21 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853103005/20001
4 years, 8 months ago (2016-04-04 21:51:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853103005/20001
4 years, 8 months ago (2016-04-05 13:24:17 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 13:25:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/59dc5424240bf5974d15624c32cfbe0ece54fddc

Powered by Google App Engine
This is Rietveld 408576698