Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: tools/nanobench_flags.py

Issue 1853103003: Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GL… (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add 'gl' to config list Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/nanobench_flags.py
diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py
index 02b885634e9c40a99703a1afc9c793eae7f0403b..b14251ed8578e0aee011c577fd0425597f10f4cb 100755
--- a/tools/nanobench_flags.py
+++ b/tools/nanobench_flags.py
@@ -49,7 +49,13 @@ def get_args(bot):
if ('GalaxyS4' not in bot and
'NexusPlayer' not in bot):
if 'Android' in bot:
- config.extend(['msaa4', 'nvpr4', 'nvprdit4'])
+ # The TegraX1 has a regular OpenGL implementation. We bench that instead
+ # of ES.
+ if 'TegraX1' in bot:
+ config.remove('gpu')
+ config.extend(['gl', 'glmsaa4', 'glnvpr4', 'glnvprdit4'])
+ else:
+ config.extend(['msaa4', 'nvpr4', 'nvprdit4'])
else:
config.extend(['msaa16', 'nvpr16', 'nvprdit16'])
args.append('--config')
@@ -150,6 +156,7 @@ def self_test():
'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug',
'Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Release',
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot',
+ 'Perf-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Release',
]
cov = coverage.coverage()
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698