Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/dm_flags.py

Issue 1853103003: Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GL… (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add 'gl' to config list Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | tools/flags/SkCommonFlagsConfig.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index 5c22a33d0d718b67cbc89cee418437e0e458dae9..fb4522c74a1c94b3e0106b18f6a549fb6e81add3 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -50,6 +50,13 @@ def get_args(bot):
else:
configs.append('nvprdit16')
+ # We want to test the OpenGL config not the GLES config on the X1
+ if 'TegraX1' in bot:
+ configs.remove('gpu')
+ configs.remove('gpusrgb')
+ configs.append('gl')
+ configs.append('glsrgb')
+
# The S4 crashes and the NP produces a long error stream when we run with
# MSAA. The Tegra2 and Tegra3 just don't support it.
if ('GalaxyS4' not in bot and
@@ -261,6 +268,7 @@ def self_test():
'Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE',
'Test-Mac10.8-Clang-MacMini4.1-CPU-SSE4-x86_64-Release',
'Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Release',
+ 'Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Release',
]
cov = coverage.coverage()
« no previous file with comments | « tools/dm_flags.json ('k') | tools/flags/SkCommonFlagsConfig.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698