Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GL…

Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003

Committed: https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89

Committed: https://skia.googlesource.com/skia/+/b8797bb7b74adcab1d198de3ef4f0871b0bb6718

[bsalomon, 2016-04-04 14:31:32]

Description was changed from

==========
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use
OpenGL rather than GLES and use them on the X1 bot
==========

to

==========
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use
OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-04 14:35:40]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, jvanverth@google.com

[bsalomon, 2016-04-04 14:35:41]

I had to revert my GrContextFactory enum rename CL because it inadvertently
caused the TegraX1 bot to run GLES rather than GL for both dm and nanobench.
Since we want to move to always being explicit anyway, this fixes it by making
new configs for the X1 that are explicity GL not GLES and updates dm_flags.py
and nanobench_flags.py to pass those configs on the X1 bot.

I'd actually land this not as a separate CL but with a reland of the
GrContextFactory enum CL.

[bsalomon, 2016-04-04 14:38:38]

https://codereview.chromium.org/1853103003/diff/1/tools/dm_flags.json
File tools/dm_flags.json (right):

https://codereview.chromium.org/1853103003/diff/1/tools/dm_flags.json#newcode...
tools/dm_flags.json:1201:
"Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Release": [
Generated by addition of additional bot name to the self test array in
dm_flags.py

https://codereview.chromium.org/1853103003/diff/1/tools/dm_flags.py
File tools/dm_flags.py (right):

https://codereview.chromium.org/1853103003/diff/1/tools/dm_flags.py#newcode54
tools/dm_flags.py:54: if 'TegraX1' in bot:
The X1 is currently not running any nvpr configs. I want to fix that separately
and make the reland just preserve existing behavior.

https://codereview.chromium.org/1853103003/diff/1/tools/nanobench_flags.json
File tools/nanobench_flags.json (right):

https://codereview.chromium.org/1853103003/diff/1/tools/nanobench_flags.json#...
tools/nanobench_flags.json:20: "nvpr4",
These changes appear to be because the self test results weren't updated when
the nvpr configs were last renamed.

https://codereview.chromium.org/1853103003/diff/1/tools/nanobench_flags.json#...
tools/nanobench_flags.json:46: ],
auto generated because of addition to the self test bot name array in
nanobench_flags.py

[bsalomon, 2016-04-04 15:28:02]

On 2016/04/04 14:35:41, bsalomon wrote:

> I'd actually land this not as a separate CL but with a reland of the
> GrContextFactory enum CL.

Actually I really realized this can land on its own before the reland of the
grcontextfactory change.

[egdaniel, 2016-04-04 19:09:20]

lgtm with comment on fixing index values in Parse test

https://codereview.chromium.org/1853103003/diff/1/tests/TestConfigParsing.cpp
File tests/TestConfigParsing.cpp (right):

https://codereview.chromium.org/1853103003/diff/1/tests/TestConfigParsing.cpp...
tests/TestConfigParsing.cpp:155: REPORTER_ASSERT(reporter,
configs[30]->asConfigGpu());
currently in ToT there is a bug with the current indices (never got updated from
a change). Hal is landed a fix for them, and then you will need to rebase and
fix your indices.

[bsalomon, 2016-04-04 20:36:47]

On 2016/04/04 19:09:20, egdaniel wrote:
> lgtm with comment on fixing index values in Parse test
> 
> https://codereview.chromium.org/1853103003/diff/1/tests/TestConfigParsing.cpp
> File tests/TestConfigParsing.cpp (right):
> 
>
https://codereview.chromium.org/1853103003/diff/1/tests/TestConfigParsing.cpp...
> tests/TestConfigParsing.cpp:155: REPORTER_ASSERT(reporter,
> configs[30]->asConfigGpu());
> currently in ToT there is a bug with the current indices (never got updated
from
> a change). Hal is landed a fix for them, and then you will need to rebase and
> fix your indices.

done

[bsalomon, 2016-04-04 20:36:52]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-04-04 20:36:52]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1853103003/#ps40001
(title: "add 'gl' to config list")

[commit-bot: I haz the power, 2016-04-04 20:36:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853103003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853103003/40001

[bsalomon, 2016-04-04 20:38:15]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-04-05 14:02:36]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-04-05 14:02:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853103003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853103003/40001

[commit-bot: I haz the power, 2016-04-05 14:03:44]

Description was changed from

==========
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use
OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use
OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89
==========

[commit-bot: I haz the power, 2016-04-05 14:03:45]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89

[bsalomon, 2016-04-05 14:26:12]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1857233002/ by bsalomon@google.com.

The reason for reverting is: causing crashes on win8 bot?.

[bsalomon, 2016-04-05 14:49:58]

Description was changed from

==========
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use
OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89
==========

to

==========
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use
OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89
==========

[bsalomon, 2016-04-05 15:48:39]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-04-05 15:48:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853103003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853103003/40001

[commit-bot: I haz the power, 2016-04-05 15:49:40]

Description was changed from

==========
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use
OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89
==========

to

==========
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use
OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89

Committed:
https://skia.googlesource.com/skia/+/b8797bb7b74adcab1d198de3ef4f0871b0bb6718
==========

[commit-bot: I haz the power, 2016-04-05 15:49:41]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b8797bb7b74adcab1d198de3ef4f0871b0bb6718