Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 18531004: Perform new space evacuation based on marking bits. (Closed)

Created:
7 years, 5 months ago by Hannes Payer (out of office)
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Perform new space evacuation based on marking bits. BUG= R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15621

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -36 lines) Patch
M src/mark-compact.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 1 2 chunks +79 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-11 09:48:20 UTC) #1
titzer
lgtm https://codereview.chromium.org/18531004/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/18531004/diff/1/src/mark-compact.cc#newcode1994 src/mark-compact.cc:1994: NewSpacePage* p) { Please add a TODO here ...
7 years, 5 months ago (2013-07-11 10:05:33 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/18531004/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/18531004/diff/1/src/mark-compact.cc#newcode1994 src/mark-compact.cc:1994: NewSpacePage* p) { On 2013/07/11 10:05:33, titzer wrote: > ...
7 years, 5 months ago (2013-07-11 11:14:16 UTC) #3
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-11 11:24:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15621 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698