Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1853033003: Fix IWYU violators that don't include scoped_ptr.h in Windows build. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
dcheng, aboxhall+watch_chromium.org, blink-worker-reviews_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, caitkp+watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, David Black, devtools-reviews_chromium.org, dhollowa+watch_chromium.org, dmazzoni+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, grt+watch_chromium.org, horo+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, je_julie, Jered, jfweitz+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+fileapi, kinuko+watch, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-permissions_chromium.org, nasko+codewatch_chromium.org, nektar+watch_chromium.org, nhiroki, ortuno+watch_chromium.org, pfeldman, piman+watch_chromium.org, rickyz+watch_chromium.org, rouslan+autofill_chromium.org, samarth+watch_chromium.org, scheib+watch_chromium.org, serviceworker-reviews, skanuj+watch_chromium.org, Lei Zhang, tommycli, tracing+reviews_chromium.org, tzik, vabr+watchlistautofill_chromium.org, wfh+watch_chromium.org, wjmaclean, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix IWYU violators that don't include scoped_ptr.h in Windows build. This blocks the conversion of //base from scoped_ptr to std::unique_ptr. BUG=554298 R=avi@chromium.org TBR=brettw@chromium.org Committed: https://crrev.com/1553708cc722dcc8ae421838d8232d3a0e10faff Cr-Commit-Position: refs/heads/master@{#384842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M chrome/browser/devtools/devtools_target_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search/thumbnail_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/input_method/input_method_engine_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_elf/blacklist/test/blacklist_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_watcher/window_hang_monitor_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/core/page_features.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/domain_reliability/scheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/guest_view/browser/guest_view_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/browser/nacl_browser.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/browser/pnacl_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/power/origin_power_map.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sessions/core/base_session_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/dragged_file_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/file_system_quota_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/recursive_operation_delegate_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/sandbox_origin_database_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/upload_file_system_file_element_reader.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/quota/quota_backend_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/quota/quota_reservation_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/quota_reservation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/quota_reservation_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/etw_system_event_consumer_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/host_zoom_map.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/navigation_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/sandbox_file_system_test_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/p2p/filtering_network_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/dwrite_font_fake_sender_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/core/device_monitor_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_find_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M gin/shell_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/win/audio_device_listener_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/transport_security_persister.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/transport_security_persister_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/win/host_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/address_sanitizer_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/win/screen_win.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
dcheng
Rawr.
4 years, 8 months ago (2016-04-04 01:02:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853033003/1
4 years, 8 months ago (2016-04-04 01:02:20 UTC) #6
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-04 01:09:47 UTC) #7
dcheng
TBRing brettw for global OWNERS stamp With any luck, https://codereview.chromium.org/1852433005 will build after this.
4 years, 8 months ago (2016-04-04 02:13:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853033003/1
4 years, 8 months ago (2016-04-04 02:13:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 02:37:05 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 02:38:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1553708cc722dcc8ae421838d8232d3a0e10faff
Cr-Commit-Position: refs/heads/master@{#384842}

Powered by Google App Engine
This is Rietveld 408576698