Use our own grapheme boundary handling.

third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/EditingUtilities.h"
 
 #include "core/dom/StaticNodeList.h"
 #include "core/editing/EditingTestBase.h"
 
 namespace blink {
@@ skipping 138 matching lines @@
 
 TEST_F(EditingUtilitiesTest, NextNodeIndex)
 {
     const char* bodyContent = "<p id='host'>00<b id='one'>11</b><b id='two'>22</b>33</p>";
     const char* shadowContent = "<content select=#two></content><content select=#one></content>";
     setBodyContent(bodyContent);
     setShadowContent(shadowContent, "host");
     Node* host = document().getElementById("host");
     Node* two = document().getElementById("two");
 
-    EXPECT_EQ(Position(host, 3), nextPositionOf(Position(two, 2), PositionMoveType::CodeUnit));
-    EXPECT_EQ(PositionInFlatTree(host, 1), nextPositionOf(PositionInFlatTree(two, 2), PositionMoveType::CodeUnit));
+    EXPECT_EQ(Position(host, 3), nextPositionOf(Position(two, 2), PositionMoveType::CodePoint));
+    EXPECT_EQ(PositionInFlatTree(host, 1), nextPositionOf(PositionInFlatTree(two, 2), PositionMoveType::CodePoint));
 }
 
 TEST_F(EditingUtilitiesTest, NextVisuallyDistinctCandidate)
 {
     const char* bodyContent = "<p id='host'>00<b id='one'>11</b><b id='two'>22</b><b id='three'>33</b></p>";
     const char* shadowContent = "<content select=#two></content><content select=#one></content><content select=#three></content>";
     setBodyContent(bodyContent);
     setShadowContent(shadowContent, "host");
     updateLayoutAndStyleForPainting();
     Node* one = document().getElementById("one");
@@ skipping 83 matching lines @@
 
     // GB2: Break at the end of text.
     setBodyContent("<p id='target'>a</p>");
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
 
     // GB3: Do not break between CR and LF.
     setBodyContent("<p id='target'>a&#x0D;&#x0A;b</p>");
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(3, previousGraphemeBoundaryOf(node, 4));
-    // TODO(nona) : Enable following expectation.
-    // EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 3));
+    EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
-    // TODO(nona) : Enable following expectation.
-    // EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 1));
+    EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 3));
 
     // GB4,GB5: Break before and after CR/LF/Control.
     setBodyContent("<p id='target'>a&#x0D;b</p>"); // CR
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(2, previousGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 2));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(2, nextGraphemeBoundaryOf(node, 1));
@@ skipping 109 matching lines @@
     // Break other Hangul syllable combination. See test of GB999.
 
     // GB8a: Don't break between regional indicator if there are even numbered regional indicator symbols before.
     // U+1F1FA is REGIONAL INDICATOR SYMBOL LETTER U.
     // U+1F1F8 is REGIONAL INDICATOR SYMBOL LETTER S.
     const std::string flag = "&#x1F1FA;&#x1F1F8;"; // US flag.
     setBodyContent("<p id='target'>" + flag + flag + flag + flag + "a</p>"); // ^(RI RI)* RI x RI
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(16, previousGraphemeBoundaryOf(node, 17));
     EXPECT_EQ(12, previousGraphemeBoundaryOf(node, 16));
-    // TODO(nona): Enable following expectations.
-    // EXPECT_EQ(8, previousGraphemeBoundaryOf(node, 12));
-    // EXPECT_EQ(4, previousGraphemeBoundaryOf(node, 8));
-    // EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 4));
-    // EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 0));
-    // EXPECT_EQ(8, nextGraphemeBoundaryOf(node, 4));
+    EXPECT_EQ(8, previousGraphemeBoundaryOf(node, 12));
+    EXPECT_EQ(4, previousGraphemeBoundaryOf(node, 8));
+    EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 4));
+    EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 0));
+    EXPECT_EQ(8, nextGraphemeBoundaryOf(node, 4));
     EXPECT_EQ(12, nextGraphemeBoundaryOf(node, 8));
     EXPECT_EQ(16, nextGraphemeBoundaryOf(node, 12));
     EXPECT_EQ(17, nextGraphemeBoundaryOf(node, 16));
 
     // GB8c: Don't break between regional indicator if there are even numbered regional indicator symbols before.
     setBodyContent("<p id='target'>a" + flag + flag + flag + flag + "b</p>"); // [^RI] (RI RI)* RI x RI
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(17, previousGraphemeBoundaryOf(node, 18));
     EXPECT_EQ(13, previousGraphemeBoundaryOf(node, 17));
-    // TODO(nona): Enable following expectations.
-    // EXPECT_EQ(9, previousGraphemeBoundaryOf(node, 13));
-    // EXPECT_EQ(5, previousGraphemeBoundaryOf(node, 9));
+    EXPECT_EQ(9, previousGraphemeBoundaryOf(node, 13));
+    EXPECT_EQ(5, previousGraphemeBoundaryOf(node, 9));
     EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 5));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
-    // TODO(nona): Enable following expectations.
-    // EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 1));
-    // EXPECT_EQ(9, nextGraphemeBoundaryOf(node, 5));
+    EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 1));
+    EXPECT_EQ(9, nextGraphemeBoundaryOf(node, 5));
     EXPECT_EQ(13, nextGraphemeBoundaryOf(node, 9));
     EXPECT_EQ(17, nextGraphemeBoundaryOf(node, 13));
     EXPECT_EQ(18, nextGraphemeBoundaryOf(node, 17));
 
     // GB8c: Break if there is an odd number of regional indicator symbols before.
     setBodyContent("<p id='target'>a" + flag + flag + flag + flag + "&#x1F1F8;b</p>"); // RI ÷ RI
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(19, previousGraphemeBoundaryOf(node, 20));
-    // TODO(nona): Enable following expectations.
-    // EXPECT_EQ(17, previousGraphemeBoundaryOf(node, 19));
-    // EXPECT_EQ(13, previousGraphemeBoundaryOf(node, 17));
-    // EXPECT_EQ(9, previousGraphemeBoundaryOf(node, 13));
-    // EXPECT_EQ(5, previousGraphemeBoundaryOf(node, 9));
+    EXPECT_EQ(17, previousGraphemeBoundaryOf(node, 19));
+    EXPECT_EQ(13, previousGraphemeBoundaryOf(node, 17));
+    EXPECT_EQ(9, previousGraphemeBoundaryOf(node, 13));
+    EXPECT_EQ(5, previousGraphemeBoundaryOf(node, 9));
     EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 5));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
-    // TODO(nona): Enable following expectations.
-    // EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 1));
-    // EXPECT_EQ(9, nextGraphemeBoundaryOf(node, 5));
-    // EXPECT_EQ(13, nextGraphemeBoundaryOf(node, 9));
+    EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 1));
+    EXPECT_EQ(9, nextGraphemeBoundaryOf(node, 5));
+    EXPECT_EQ(13, nextGraphemeBoundaryOf(node, 9));
     EXPECT_EQ(17, nextGraphemeBoundaryOf(node, 13));
     EXPECT_EQ(19, nextGraphemeBoundaryOf(node, 17));
     EXPECT_EQ(20, nextGraphemeBoundaryOf(node, 19));
 
     // GB9: Do not break before extending characters or ZWJ.
     // U+0300(COMBINING GRAVE ACCENT) has Extend property.
     setBodyContent("<p id='target'>a&#x0300;b</p>"); // x Extend
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(2, previousGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 2));
     EXPECT_EQ(2, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 2));
     // U+200D is ZERO WIDTH JOINER.
     setBodyContent("<p id='target'>a&#x200D;b</p>"); // x ZWJ
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(2, previousGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 2));
     EXPECT_EQ(2, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 2));
 
     // GB9a: Do not break before SpacingMarks.
     // U+0903(DEVANAGARI SIGN VISARGA) has SpacingMark property.
     setBodyContent("<p id='target'>a&#x0903;b</p>"); // x SpacingMark
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(2, previousGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 2));
     EXPECT_EQ(2, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 2));
 
-    // GB9b: Do not break after Prepend but Blink breaks after Prepend char to address Bug 24342.
-    // U+0600(ARABIC NUMBER SIGN) has Prepend property.
-    setBodyContent("<p id='target'>a&#x0600;b</p>"); // Prepend x
+    // GB9b: Do not break after Prepend.
+    // TODO(nona): Introduce Prepend test case once ICU grabs Unicode 9.0.
+
+    // For https://bugs.webkit.org/show_bug.cgi?id=24342
+    // The break should happens after Thai character.
+    setBodyContent("<p id='target'>a&#x0E40;b</p>");
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(2, previousGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 2));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(2, nextGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 2));
 
     // Blink customization: Don't break before Japanese half-width katakana voiced marks.
     setBodyContent("<p id='target'>a&#xFF76;&#xFF9E;b</p>");
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(3, previousGraphemeBoundaryOf(node, 4));
     EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 3));
 
-    // Additional rule for Virama: Do not break after Virama except for Tamil.
+    // Additional rule for IndicSyllabicCategory=Virama: Do not break after that.
     // See http://www.unicode.org/Public/9.0.0/ucd/IndicSyllabicCategory-9.0.0d2.txt
     // U+0905 is DEVANAGARI LETTER A. This has Extend property.
     // U+094D is DEVANAGARI SIGN VIRAMA. This has Virama property.
     // U+0915 is DEVANAGARI LETTER KA.
     setBodyContent("<p id='target'>a&#x0905;&#x094D;&#x0915;b</p>");
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(4, previousGraphemeBoundaryOf(node, 5));
     EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 4));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 4));
-    // U+0B85 is TAMIL LETTER A. This has Extend property.
-    // U+0BCD is TAMIL SIGN VIRAMA. This has Virama property.
-    // U+0B95 is TAMIL LETTER KA.
-    setBodyContent("<p id='target'>a&#x0B85;&#x0BCD;&#x0B95;b</p>");
+    // U+0E01 is THAI CHARACTER KO KAI
+    // U+0E3A is THAI CHARACTER PHINTHU
+    // Should break after U+0E3A since U+0E3A has Virama property but not listed in
+    // IndicSyllabicCategory=Virama.
+    setBodyContent("<p id='target'>a&#x0E01;&#x0E3A;&#x0E01;b</p>");
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(4, previousGraphemeBoundaryOf(node, 5));
     EXPECT_EQ(3, previousGraphemeBoundaryOf(node, 4));
     EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 3));
     EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 4));
-    // TODO(nona): Consider to add Sinhala, Balinese, etc.
 
     // GB10: Do not break within emoji modifier.
     // U+1F385(FATHER CHRISTMAS) has E_Base property.
     // U+1F3FB(EMOJI MODIFIER FITZPATRICK TYPE-1-2) has E_Modifier property.
     setBodyContent("<p id='target'>a&#x1F385;&#x1F3FB;b</p>"); // E_Base x E_Modifier
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(5, previousGraphemeBoundaryOf(node, 6));
-    // TODO(nona): Enable following expectation.
-    // EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 5));
+    EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 5));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
-    // TODO(nona): Enable following expectation.
-    // EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 1));
+    EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(6, nextGraphemeBoundaryOf(node, 5));
     // U+1F466(BOY) has EBG property.
     setBodyContent("<p id='target'>a&#x1F466;&#x1F3FB;b</p>"); // EBG x E_Modifier
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(5, previousGraphemeBoundaryOf(node, 6));
-    // TODO(nona): Enable following expectation.
-    // EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 5));
+    EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 5));
     EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
-    // TODO(nona): Enable following expectation.
-    // EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 1));
+    EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 1));
     EXPECT_EQ(6, nextGraphemeBoundaryOf(node, 5));
 
     // GB11: Do not break within ZWJ emoji sequence.
     // U+2764(HEAVY BLACK HEART) has Glue_After_Zwj property.
     setBodyContent("<p id='target'>a&#x200D;&#x2764;b</p>"); // ZWJ x Glue_After_Zwj
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(3, previousGraphemeBoundaryOf(node, 4));
-    // TODO(nona): Enable following expectation.
-    // EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 3));
-    // EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 0));
+    EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 3));
+    EXPECT_EQ(3, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 3));
     setBodyContent("<p id='target'>a&#x200D;&#x1F466;b</p>"); // ZWJ x EBG
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(4, previousGraphemeBoundaryOf(node, 5));
-    // TODO(nona): Enable following expectation.
-    // EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 4));
-    // EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 0));
+    EXPECT_EQ(0, previousGraphemeBoundaryOf(node, 4));
+    EXPECT_EQ(4, nextGraphemeBoundaryOf(node, 0));
     EXPECT_EQ(5, nextGraphemeBoundaryOf(node, 4));
 
     // GB999: Otherwise break everywhere.
     // Breaks between Hangul syllable except for GB6, GB7, GB8.
     setBodyContent("<p id='target'>" + L + T + "</p>");
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(1, previousGraphemeBoundaryOf(node, 2));
     EXPECT_EQ(1, nextGraphemeBoundaryOf(node, 0));
     setBodyContent("<p id='target'>" + V + L + "</p>");
     node = document().getElementById("target")->firstChild();
@@ skipping 163 matching lines @@
 
     // Edge case: specify middle of surrogate pairs.
     setBodyContent("<p id='target'>&#x1F441;&#x1F441;&#x1F441</p>");
     node = document().getElementById("target")->firstChild();
     EXPECT_EQ(Position(node, 4), previousPositionOf(Position(node, 5), PositionMoveType::BackwardDeletion));
     EXPECT_EQ(Position(node, 2), previousPositionOf(Position(node, 3), PositionMoveType::BackwardDeletion));
     EXPECT_EQ(Position(node, 0), previousPositionOf(Position(node, 1), PositionMoveType::BackwardDeletion));
 }
 
 } // namespace blink