Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1852993002: [Media Router WebUI] Fix search input highlight. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix search input highlight. This change fixes a couple things with the search input focus highlight: - Remove whitespace also highlighted to the right (end) of the paper-input element. - Switch the vertical padding to margins to remove highlighted whitespace. BUG=599082 Committed: https://crrev.com/1efe54553fb263551dc16698be33f3a6a19fe7ff Cr-Commit-Position: refs/heads/master@{#385030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
apacible
PTAL, thanks! See BUG for previous focus highlight. Screenshot: https://screenshot.googleplex.com/Gkby7pgrOHq.png
4 years, 8 months ago (2016-04-02 06:22:16 UTC) #5
mark a. foltz
LGTM
4 years, 8 months ago (2016-04-04 20:43:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852993002/1
4 years, 8 months ago (2016-04-04 21:10:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 22:25:17 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 22:27:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1efe54553fb263551dc16698be33f3a6a19fe7ff
Cr-Commit-Position: refs/heads/master@{#385030}

Powered by Google App Engine
This is Rietveld 408576698