chrome/common/logging_chrome.cc - Issue 1852953002: Fix a bunch of IWYU violators that don't include scoped_ptr.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/logging_chrome.cc

Issue 1852953002: Fix a bunch of IWYU violators that don't include scoped_ptr.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/component_flash_hint_file_linux.cc ('k') | chrome/common/safe_browsing/binary_feature_extractor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/logging_chrome.cc

diff --git a/chrome/common/logging_chrome.cc b/chrome/common/logging_chrome.cc

index a0b2e9c1f58e5cb2b8a46ca809098f2e271f9cb5..7f8d908d6e59a67a2ce8500e3bebe0cfbda3a429 100644

--- a/chrome/common/logging_chrome.cc

+++ b/chrome/common/logging_chrome.cc

@@ -2,8 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "base/memory/scoped_ptr.h"

danakj 2016/04/02 01:02:16 The header should go down with the rest around l35

dcheng 2016/04/02 01:11:43 Ahhh this file is a mess. Fixed.

#include "build/build_config.h"

dcheng 2016/04/02 00:36:26 I'll restore this newline, just noticed the script

dcheng 2016/04/02 00:54:06 Restored, PTAL.

// Need to include this before most other files because it defines

// IPC_MESSAGE_LOG_ENABLED. We need to use it to define

// IPC_MESSAGE_MACROS_LOG_ENABLED so render_messages.h will generate the