Use schema generated event classes for bookmarks API.

Use schema generated event classes for bookmarks API.

Converts bookmarks and bookmarkManagerPrivate event related functions
to use the schema generated classes instead of manually constructing
JSON objects.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255290

[not at google - send to devlin, 2014-03-05 00:18:06]

lgtm

https://codereview.chromium.org/185293019/diff/10001/chrome/browser/extension...
File
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
(left):

https://codereview.chromium.org/185293019/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc:199:
void BookmarkManagerPrivateEventRouter::DispatchDragEvent(
You could keep the gist of this function like:

template <typename EventType>
void DispatchDragEvent<EventType>(const BookmarkNodeData& data) {
  if (data.size() == 0) return;
  DispatchEvent(EventType::kEventName,
                EventType::Create(*CreateApiBookmarkNodeData(profile_, data)));
}

https://codereview.chromium.org/185293019/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/api/bookmarks/bookmarks_api.cc (right):

https://codereview.chromium.org/185293019/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bookmarks/bookmarks_api.cc:173: void
BookmarkEventRouter::DispatchEvent(
Similarly you could templatise this if you wanted.

[Rune Fevang, 2014-03-05 01:00:34]

https://codereview.chromium.org/185293019/diff/10001/chrome/browser/extension...
File
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
(left):

https://codereview.chromium.org/185293019/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc:199:
void BookmarkManagerPrivateEventRouter::DispatchDragEvent(
On 2014/03/05 00:18:06, kalman wrote:
> You could keep the gist of this function like:
> 
> template <typename EventType>
> void DispatchDragEvent<EventType>(const BookmarkNodeData& data) {
>   if (data.size() == 0) return;
>   DispatchEvent(EventType::kEventName,
>                 EventType::Create(*CreateApiBookmarkNodeData(profile_,
data)));
> }

This doesn't appear to work, as the types in questions are namespaces and not
classes.

[Rune Fevang, 2014-03-05 20:30:06]

The CQ bit was checked by rfevang@chromium.org

[commit-bot: I haz the power, 2014-03-05 20:31:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rfevang@chromium.org/185293019/10001

[commit-bot: I haz the power, 2014-03-05 20:46:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 20:46:38]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Rune Fevang, 2014-03-05 21:34:11]

The CQ bit was checked by rfevang@chromium.org

[commit-bot: I haz the power, 2014-03-05 21:35:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rfevang@chromium.org/185293019/30001

[commit-bot: I haz the power, 2014-03-06 00:02:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rfevang@chromium.org/185293019/30001

[commit-bot: I haz the power, 2014-03-06 00:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 00:49:24]

Try jobs failed on following builders: mac_chromium_rel

[Rune Fevang, 2014-03-06 06:46:25]

The CQ bit was checked by rfevang@chromium.org

[commit-bot: I haz the power, 2014-03-06 06:46:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rfevang@chromium.org/185293019/30001

[commit-bot: I haz the power, 2014-03-06 10:22:22]

Change committed as 255290