Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: extensions/browser/extension_function_registry.h

Issue 185293017: Move ExtensionFunctionRegistry out of src/chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_function_registry.h
diff --git a/chrome/browser/extensions/extension_function_registry.h b/extensions/browser/extension_function_registry.h
similarity index 80%
rename from chrome/browser/extensions/extension_function_registry.h
rename to extensions/browser/extension_function_registry.h
index 60b77f0ca8ab63d089c5b3ab6333ca1597838e9d..fa3d2e800b5c4564d1d2e56765a472ea5a6aaec4 100644
--- a/chrome/browser/extensions/extension_function_registry.h
+++ b/extensions/browser/extension_function_registry.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_REGISTRY_H_
-#define CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_REGISTRY_H_
+#ifndef EXTENSIONS_BROWSER_EXTENSION_FUNCTION_REGISTRY_H_
+#define EXTENSIONS_BROWSER_EXTENSION_FUNCTION_REGISTRY_H_
#include <map>
#include <string>
@@ -17,7 +17,7 @@ class ExtensionFunction;
typedef ExtensionFunction* (*ExtensionFunctionFactory)();
// Template for defining ExtensionFunctionFactory.
-template<class T>
+template <class T>
ExtensionFunction* NewExtensionFunction() {
return new T();
}
@@ -30,9 +30,6 @@ class ExtensionFunctionRegistry {
explicit ExtensionFunctionRegistry();
virtual ~ExtensionFunctionRegistry();
- // Resets all functions to their default values.
- void ResetFunctions();
-
// Adds all function names to 'names'.
void GetAllNames(std::vector<std::string>* names);
@@ -44,7 +41,7 @@ class ExtensionFunctionRegistry {
// Factory method for the ExtensionFunction registered as 'name'.
ExtensionFunction* NewFunction(const std::string& name);
- template<class T>
+ template <class T>
void RegisterFunction() {
ExtensionFunctionFactory factory = &NewExtensionFunction<T>;
factories_[T::function_name()] =
@@ -54,8 +51,9 @@ class ExtensionFunctionRegistry {
struct FactoryEntry {
public:
explicit FactoryEntry();
- explicit FactoryEntry(ExtensionFunctionFactory factory,
- extensions::functions::HistogramValue histogram_value);
+ explicit FactoryEntry(
+ ExtensionFunctionFactory factory,
+ extensions::functions::HistogramValue histogram_value);
ExtensionFunctionFactory factory_;
extensions::functions::HistogramValue histogram_value_;
@@ -65,4 +63,4 @@ class ExtensionFunctionRegistry {
FactoryMap factories_;
};
-#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_REGISTRY_H_
+#endif // EXTENSIONS_BROWSER_EXTENSION_FUNCTION_REGISTRY_H_

Powered by Google App Engine
This is Rietveld 408576698