Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185293017: Move ExtensionFunctionRegistry out of src/chrome (Closed)

Created:
6 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Move ExtensionFunctionRegistry out of src/chrome This is mostly a mechanical change with the exception that ExtensionsBrowserClient has a new method for registering additional extensions functions with the registry. Chrome-dependent function registration has been moved to the ChromeExtensionsBrowserClient implementation. BUG=299187 TBR=zelidrag@chromium.org,finnur@chromium.org,nona@chromium.org,stevenjb@chromium.org,kalman@chromium.org,zork@chromium.org,dmazzoni@chromium.org for mechanical header path changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255101

Patch Set 1 #

Total comments: 8

Patch Set 2 : nits etc #

Patch Set 3 : . #

Total comments: 3

Patch Set 4 : remove #if #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : move preprocess check to ChromeExtensionsBrowserClient #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -244 lines) Patch
M apps/shell/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M apps/shell/browser/shell_extensions_browser_client.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M apps/shell/browser/shell_extensions_browser_client.cc View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 2 3 4 5 6 3 chunks +41 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 3 chunks +1 line, -5 lines 0 comments Download
D chrome/browser/extensions/extension_function_registry.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/extensions/extension_function_registry.cc View 1 chunk +0 lines, -96 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
A + extensions/browser/extension_function_registry.h View 6 chunks +8 lines, -10 lines 0 comments Download
A + extensions/browser/extension_function_registry.cc View 1 2 3 4 5 6 3 chunks +14 lines, -47 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/cpp_bundle_generator.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (0 generated)
Ken Rockot(use gerrit already)
6 years, 9 months ago (2014-03-04 17:39:11 UTC) #1
James Cook
LGTM with nits https://codereview.chromium.org/185293017/diff/1/apps/shell/browser/shell_extensions_browser_client.cc File apps/shell/browser/shell_extensions_browser_client.cc (right): https://codereview.chromium.org/185293017/diff/1/apps/shell/browser/shell_extensions_browser_client.cc#newcode160 apps/shell/browser/shell_extensions_browser_client.cc:160: // TODO(rockot): Remove this once we ...
6 years, 9 months ago (2014-03-04 18:03:20 UTC) #2
Ken Rockot(use gerrit already)
+jyasskin Could you please take a look as owner of c/b/e? https://codereview.chromium.org/185293017/diff/1/apps/shell/browser/shell_extensions_browser_client.cc File apps/shell/browser/shell_extensions_browser_client.cc (right): ...
6 years, 9 months ago (2014-03-04 19:14:38 UTC) #3
Jeffrey Yasskin
lgtm, but see if you can get rid of the #if. https://codereview.chromium.org/185293017/diff/40001/extensions/browser/extension_function_registry.cc File extensions/browser/extension_function_registry.cc (right): ...
6 years, 9 months ago (2014-03-04 23:30:15 UTC) #4
James Cook
https://codereview.chromium.org/185293017/diff/40001/extensions/browser/extension_function_registry.cc File extensions/browser/extension_function_registry.cc (right): https://codereview.chromium.org/185293017/diff/40001/extensions/browser/extension_function_registry.cc#newcode18 extensions/browser/extension_function_registry.cc:18: #if defined(ENABLE_EXTENSIONS) On 2014/03/04 23:30:16, Jeffrey Yasskin wrote: > ...
6 years, 9 months ago (2014-03-04 23:55:05 UTC) #5
Ken Rockot(use gerrit already)
https://codereview.chromium.org/185293017/diff/40001/extensions/browser/extension_function_registry.cc File extensions/browser/extension_function_registry.cc (right): https://codereview.chromium.org/185293017/diff/40001/extensions/browser/extension_function_registry.cc#newcode18 extensions/browser/extension_function_registry.cc:18: #if defined(ENABLE_EXTENSIONS) On 2014/03/04 23:55:06, James Cook wrote: > ...
6 years, 9 months ago (2014-03-05 00:18:44 UTC) #6
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-05 04:42:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/185293017/80001
6 years, 9 months ago (2014-03-05 04:47:09 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 06:32:33 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=157251
6 years, 9 months ago (2014-03-05 06:32:34 UTC) #10
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-05 07:08:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/185293017/80001
6 years, 9 months ago (2014-03-05 07:09:47 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 08:18:25 UTC) #13
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=157300
6 years, 9 months ago (2014-03-05 08:18:25 UTC) #14
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-05 13:52:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/185293017/100001
6 years, 9 months ago (2014-03-05 13:53:01 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 15:16:46 UTC) #17
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=157391
6 years, 9 months ago (2014-03-05 15:16:46 UTC) #18
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-05 15:41:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/185293017/120001
6 years, 9 months ago (2014-03-05 15:41:57 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 15:45:09 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-05 15:45:10 UTC) #22
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 9 months ago (2014-03-05 15:53:00 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/185293017/120001
6 years, 9 months ago (2014-03-05 15:53:10 UTC) #24
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 18:47:36 UTC) #25
Message was sent while issue was closed. 
Change committed as 255101

Powered by Google App Engine
This is Rietveld 408576698