Don't use RenderStyle::clone unless there is actually a RenderObject to attach the cloned style to.

Don't use RenderStyle::clone unless there is actually a RenderObject to attach the cloned style to.

Non-renderer-based elements such as optGroup do not have renderers.
BUG=348330
R=esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168394

[esprehn, 2014-03-03 19:24:27]

Hmm, this clone logic doesn't look right either. You want setStyleInternal not
setStyle. You're making the RenderObject go through a styleWillChange and
styleDidChange and all the associated work outside recalcStyle.

[chrishtr, 2014-03-03 21:14:29]

Done. Good catch.

[esprehn, 2014-03-03 21:43:52]

lgtm, please simplify before landing. You don't need the boolean.

https://codereview.chromium.org/185293011/diff/140001/Source/core/css/RuleFea...
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/185293011/diff/140001/Source/core/css/RuleFea...
Source/core/css/RuleFeature.cpp:438: if (RenderStyle* renderStyle =
renderer->style()) {
If you have a renderer you must have a style, this all collapses down to:

if (RenderObject* renderer = element->renderer())
  renderer->setStyleInternal(RenderStyle::clone(renderer->style()));
else
  element->setNeedsStyleRecalc(LocalStyleChange);

[chrishtr, 2014-03-03 21:53:36]

https://codereview.chromium.org/185293011/diff/140001/Source/core/css/RuleFea...
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/185293011/diff/140001/Source/core/css/RuleFea...
Source/core/css/RuleFeature.cpp:438: if (RenderStyle* renderStyle =
renderer->style()) {
On 2014/03/03 21:43:52, esprehn wrote:
> If you have a renderer you must have a style, this all collapses down to:
> 
> if (RenderObject* renderer = element->renderer())
>   renderer->setStyleInternal(RenderStyle::clone(renderer->style()));
> else
>   element->setNeedsStyleRecalc(LocalStyleChange);

Done.

[chrishtr, 2014-03-03 23:22:16]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-03-03 23:25:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrishtr@chromium.org/185293011/160001

[commit-bot: I haz the power, 2014-03-04 13:45:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-04 13:45:38]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[chrishtr, 2014-03-04 17:12:00]

Committed patchset #9 manually as r168394 (presubmit successful).