Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 185293007: Add visualization of clips to debugger (Closed)

Created:
6 years, 9 months ago by robertphillips
Modified:
6 years, 9 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

The new "mega" viz mode both adds visualization and forces all drawing to the visible canvas (by replacing the active saveLayers with saves). Committed: http://code.google.com/p/skia/source/detail?r=13640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -13 lines) Patch
M debugger/QT/SkDebuggerGUI.h View 1 chunk +5 lines, -0 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M debugger/QT/SkSettingsWidget.h View 2 chunks +7 lines, -1 line 0 comments Download
M debugger/QT/SkSettingsWidget.cpp View 3 chunks +9 lines, -3 lines 0 comments Download
M debugger/SkDebugger.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 6 chunks +89 lines, -7 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 5 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 9 months ago (2014-03-02 22:55:33 UTC) #1
bsalomon
lgtm
6 years, 9 months ago (2014-03-03 14:54:47 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 9 months ago (2014-03-03 15:12:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/185293007/1
6 years, 9 months ago (2014-03-03 15:13:07 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 16:32:28 UTC) #5
Message was sent while issue was closed.
Change committed as 13640

Powered by Google App Engine
This is Rietveld 408576698