Issue 185293007: Add visualization of clips to debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185293007: Add visualization of clips to debugger (Closed)

Created:
6 years, 9 months ago by robertphillips

Modified:
6 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The new "mega" viz mode both adds visualization and forces all drawing to the visible canvas (by replacing the active saveLayers with saves). Committed: http://code.google.com/p/skia/source/detail?r=13640

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -13 lines)			Patch
M	debugger/QT/SkDebuggerGUI.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	debugger/QT/SkSettingsWidget.cpp	View	3 chunks	+9 lines, -3 lines	0 comments	Download
M	debugger/SkDebugger.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.cpp	View	6 chunks	+89 lines, -7 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.h	View	5 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 9 months ago (2014-03-03 15:12:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/185293007/1

6 years, 9 months ago (2014-03-03 15:13:07 UTC) #4

Message was sent while issue was closed.

Change committed as 13640

Expand Messages | Collapse Messages