Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 185293006: Move almost all of CSSPropertyParser into CSSPropertyParser.cpp (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
Reviewers:
eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move almost all of CSSPropertyParser into CSSPropertyParser.cpp This moves 8200 lines out of BisonCSSParser leaving only 1700 lines left. :) When I split CSSPropertyParser from BisonCSSParser I left all the code in BisonCSSParser-in.cpp to make the diff small and to avoid conflicting with others changes. Now I'm moving (almost) all of CSSPropertyParser into the correct .cpp file. The only bit left is some transform parsing code which uses the -in.cpp preprocessor bits of BisonCSSParser. Its the only code which uses this fancy SWITCH/CASE preprocessor and should just be moved out into its own file. BUG=330389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168368

Patch Set 1 #

Patch Set 2 : Do a better code move #

Patch Set 3 : Fix link errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8199 lines, -8139 lines) Patch
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 7 chunks +195 lines, -8138 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 2 chunks +8000 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rwlbuis
The latest patchset seems to work well. Let me know if we'll go with this ...
6 years, 9 months ago (2014-03-03 15:54:11 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-03 19:19:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/185293006/10005
6 years, 9 months ago (2014-03-03 19:19:33 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:04:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24800
6 years, 9 months ago (2014-03-03 20:04:40 UTC) #5
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-03 20:27:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/185293006/10005
6 years, 9 months ago (2014-03-03 20:28:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/185293006/10005
6 years, 9 months ago (2014-03-03 23:20:42 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 07:21:44 UTC) #9
Message was sent while issue was closed.
Change committed as 168368

Powered by Google App Engine
This is Rietveld 408576698