Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1852883002: Include the missing deps//ui/resources:ui_test_pak to make ResourceBundle work in views_unittests. (Closed)

Created:
4 years, 8 months ago by xdai1
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include the missing deps//ui/resources:ui_test_pak to make ResourceBundle work in views_unittests. BUG=594278 Committed: https://crrev.com/4a17bef0d43cea3ff99446628379feb642adcd7f Cr-Commit-Position: refs/heads/master@{#384761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xdai1
sky@, could you help review this CL please? Thanks!
4 years, 8 months ago (2016-04-01 22:12:51 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-01 23:57:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852883002/1
4 years, 8 months ago (2016-04-02 00:04:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 00:50:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 00:51:29 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4a17bef0d43cea3ff99446628379feb642adcd7f
Cr-Commit-Position: refs/heads/master@{#384761}

Powered by Google App Engine
This is Rietveld 408576698